ION606
commented
7 months ago I can try and work on this :3
Closed jamiereynolds1989 closed 7 months ago
ION606
commented
7 months ago I can try and work on this :3
jamiereynolds1989
commented
7 months ago that would be awesome if you could get it working, hope you can do it!
On Wed, Mar 27, 2024 at 12:39 AM ION606 @.***> wrote:
I can try and work on this :3
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2021715602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ5LJQI6O7FDYWQNBS3Y2IIM5AVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRG4YTKNRQGI . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago Hi, thank you for making this! Really appreciated.
There's a few bugs, it keeps reverting back to 00:00 elapsed time and not displaying current articles correctly.
Also, is it possible to have the article headline displayed rather than the person who wrote it?
Thanks!
On Sat, Mar 30, 2024 at 11:02 PM Bas van Zanten @.***> wrote:
Closed #7600 https://github.com/PreMiD/Presences/issues/7600 as completed via #8221 https://github.com/PreMiD/Presences/pull/8221.
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#event-12301909357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ66QISBA3PCKC77SLLY2477FAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMYDCOJQHEZTKNY . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago Also, would it be possible to have the articles picture as the thumbnail (or at least an option for it, like with the YouTube presence) instead of the DailyMail logo/ I think that would be brilliant if possible!
On Sun, Mar 31, 2024 at 8:15 AM Jamie Reynolds < @.***> wrote:
Hi, thank you for making this! Really appreciated.
There's a few bugs, it keeps reverting back to 00:00 elapsed time and not displaying current articles correctly.
Also, is it possible to have the article headline displayed rather than the person who wrote it?
Thanks!
On Sat, Mar 30, 2024 at 11:02 PM Bas van Zanten @.***> wrote:
Closed #7600 https://github.com/PreMiD/Presences/issues/7600 as completed via #8221 https://github.com/PreMiD/Presences/pull/8221.
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#event-12301909357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ66QISBA3PCKC77SLLY2477FAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMYDCOJQHEZTKNY . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago so the changes would be:
For the timestamp problems could you reply to this with screenshots of the issue please?
ION606
commented
7 months ago as for the other issues, see https://github.com/PreMiD/Presences/pull/8231
jamiereynolds1989
commented
7 months ago yes, the time stamp for me keeps reverting back to 00:00 but for my friend it's working fine. Weird. Not sure if that's just for me though as stated, my my friend it's fine...
an option to display current article thumbnail instead of daily mail logo would be great.
yes, displaying article headlines instead of who wrote the article, 90%+ show who wrote it and not the actual article headline, I found an article that showed the headline instead, having it that way for ALL articles would be way better imho. I will attach screenshots. (It's the Man City v Arsenal One - displaying it liek that would be way better)
Also, when I go to sports category etc, it says I'm viewing 'My Online Radio' when I am not.
I'm sure you'll know how to fix these issues, and if you do I'd really appreciate it, such a cool presence! Thanks again!
On Sun, Mar 31, 2024 at 6:55 PM ION606 @.***> wrote:
so the changes would be:
- timestamp fix
- article thumbnail instead of daily mail logo
- display article headline?
For the timestamp and article headline problems could you reply to this with screenshots of the issue please?
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2028844687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ6QLECUIBJRS56LSQTY3BEYFAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHA2DINRYG4 . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago most (or hopefully all) of these should get fixed when the pull request is merged ^~^
jamiereynolds1989
commented
7 months ago Awesome, thanks!
On Sun, Mar 31, 2024 at 11:36 PM ION606 @.***> wrote:
most (or hopefully all) of these should get fixed when the pull request is merged ^~^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2028934757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ2SOKMHYEDAKFMUFDTY3CFVDAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHEZTINZVG4 . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago How long till they are merged?
On Mon, Apr 1, 2024 at 10:02 AM Jamie Reynolds < @.***> wrote:
Awesome, thanks!
On Sun, Mar 31, 2024 at 11:36 PM ION606 @.***> wrote:
most (or hopefully all) of these should get fixed when the pull request is merged ^~^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2028934757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ2SOKMHYEDAKFMUFDTY3CFVDAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHEZTINZVG4 . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago supposedly yesterday but I've spent the past 24 hours throwing up so tmw I hope
jamiereynolds1989
commented
7 months ago hope you're feeling better soon :)
On Wed, Apr 3, 2024 at 5:44 AM ION606 @.***> wrote:
supposedly yesterday but I've spent the past 24 hours throwing up so tmw I hope
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2033520292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3VDSWII5KZOPG4RG3Y3OCLJAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGUZDAMRZGI . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago hope you're feeling better soon :)
On Wed, Apr 3, 2024 at 5:44 AM ION606 @.***> wrote:
supposedly yesterday but I've spent the past 24 hours throwing up so tmw I
hope
—
Reply to this email directly, view it on GitHub
https://github.com/PreMiD/Presences/issues/7600#issuecomment-2033520292,
or unsubscribe
.
You are receiving this because you authored the thread.Message ID:
@.***>
awwww thankies ^~^ also, it just got merged so you should be good now, you can also ping me if something else goes wrong ^^
jamiereynolds1989
commented
7 months ago No problem!
Ok, it's still got the same issues as before, but after clicking on all the categories and many articles, it DOES display correctly for like 5-10% of the categories I click on, ( ''Showbiz'' ''Science'' and ''Royals'' display the category perfectly fine stating I'm in them so it will display what category I'm viewing for some of them and just say ''browsing the news'' for the rest, and as for articles, it display the actual article header like 5% of the articles, and sometimes, but rrarely with the article thumbnail, but majority just saying ''browsing the new'' regardless of what category or article I'm viewing. So I have seen it working correctly here and there but mostly it's still like before, and time elapsed still seems to be broken, resetting to 0 seconds all the time after a few seconds. Any idea what's causing this? I knew it would be a hard presence to do so the fact you've even got it working this much is impressive to me.Hopefully you can fix these issues. Maybe you can install the presence and have a look to see what I'm talking about better? [image: image.png]
[image: image.png]
On Fri, Apr 5, 2024 at 6:25 PM ION606 @.***> wrote:
hope you're feeling better soon :)
On Wed, Apr 3, 2024 at 5:44 AM ION606 @.***> wrote:
supposedly yesterday but I've spent the past 24 hours throwing up so tmw I
hope
—
Reply to this email directly, view it on GitHub
7600 (comment)
https://github.com/PreMiD/Presences/issues/7600#issuecomment-2033520292,
or unsubscribe
.
You are receiving this because you authored the thread.Message ID:
@.***>
awwww thankies ^~^ also, it just got merged so you should be good now, you can also ping me if something else goes wrong ^^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040299549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZYVFGODM6FVUTNITA3Y33M7XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGI4TSNJUHE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago it seems to display correctly the most on ''home'' category and stories clicked inside there, but still not always. 90% of the articles in the other categories then display like they did previously, so I'm not sure if it needs to be coded separately for each category? I have no idea how it works but the fact it can display correctly shows it's working but it just isn't for 90% of the website. Hopefully you know why and that it's an easy(ish) fix?
On Fri, Apr 5, 2024 at 9:39 PM Jamie Reynolds < @.***> wrote:
No problem!
Ok, it's still got the same issues as before, but after clicking on all the categories and many articles, it DOES display correctly for like 5-10% of the categories I click on, ( ''Showbiz'' ''Science'' and ''Royals'' display the category perfectly fine stating I'm in them so it will display what category I'm viewing for some of them and just say ''browsing the news'' for the rest, and as for articles, it display the actual article header like 5% of the articles, and sometimes, but rrarely with the article thumbnail, but majority just saying ''browsing the new'' regardless of what category or article I'm viewing. So I have seen it working correctly here and there but mostly it's still like before, and time elapsed still seems to be broken, resetting to 0 seconds all the time after a few seconds. Any idea what's causing this? I knew it would be a hard presence to do so the fact you've even got it working this much is impressive to me.Hopefully you can fix these issues. Maybe you can install the presence and have a look to see what I'm talking about better? [image: image.png]
[image: image.png]
On Fri, Apr 5, 2024 at 6:25 PM ION606 @.***> wrote:
hope you're feeling better soon :)
On Wed, Apr 3, 2024 at 5:44 AM ION606 @.***> wrote:
supposedly yesterday but I've spent the past 24 hours throwing up so tmw I
hope
—
Reply to this email directly, view it on GitHub
7600 (comment)
https://github.com/PreMiD/Presences/issues/7600#issuecomment-2033520292 ,
or unsubscribe
.
You are receiving this because you authored the thread.Message ID:
@.***>
awwww thankies ^~^ also, it just got merged so you should be good now, you can also ping me if something else goes wrong ^^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040299549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZYVFGODM6FVUTNITA3Y33M7XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGI4TSNJUHE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago ok so if I click in an article in https://www.dailymail.co.uk/news/ for example, the thumbnail loads fine and the article header displays fine (just time elapsed is broken still) but soon as I click on an article on the right that takes me to a difference category, it's back to how it was before, not displaying correctly, so whatever you did for the ''news'' category, it's working perfect, but the rest aren't, so I'm buessing each category needs doing one by one, not to mention the sub categories too? So that seems like it would be way too much effort to do? But like I said I have absolutely no idea if that's the case so hopefully it's not as complicated as that. Let me know, thanks! And hope you're feelin better by now :)
On Fri, Apr 5, 2024 at 9:47 PM Jamie Reynolds < @.***> wrote:
it seems to display correctly the most on ''home'' category and stories clicked inside there, but still not always. 90% of the articles in the other categories then display like they did previously, so I'm not sure if it needs to be coded separately for each category? I have no idea how it works but the fact it can display correctly shows it's working but it just isn't for 90% of the website. Hopefully you know why and that it's an easy(ish) fix?
On Fri, Apr 5, 2024 at 9:39 PM Jamie Reynolds < @.***> wrote:
No problem!
Ok, it's still got the same issues as before, but after clicking on all the categories and many articles, it DOES display correctly for like 5-10% of the categories I click on, ( ''Showbiz'' ''Science'' and ''Royals'' display the category perfectly fine stating I'm in them so it will display what category I'm viewing for some of them and just say ''browsing the news'' for the rest, and as for articles, it display the actual article header like 5% of the articles, and sometimes, but rrarely with the article thumbnail, but majority just saying ''browsing the new'' regardless of what category or article I'm viewing. So I have seen it working correctly here and there but mostly it's still like before, and time elapsed still seems to be broken, resetting to 0 seconds all the time after a few seconds. Any idea what's causing this? I knew it would be a hard presence to do so the fact you've even got it working this much is impressive to me.Hopefully you can fix these issues. Maybe you can install the presence and have a look to see what I'm talking about better? [image: image.png]
[image: image.png]
On Fri, Apr 5, 2024 at 6:25 PM ION606 @.***> wrote:
hope you're feeling better soon :)
On Wed, Apr 3, 2024 at 5:44 AM ION606 @.***> wrote:
supposedly yesterday but I've spent the past 24 hours throwing up so tmw I
hope
—
Reply to this email directly, view it on GitHub
7600 (comment)
https://github.com/PreMiD/Presences/issues/7600#issuecomment-2033520292 ,
or unsubscribe
.
You are receiving this because you authored the thread.Message ID:
@.***>
awwww thankies ^~^ also, it just got merged so you should be good now, you can also ping me if something else goes wrong ^^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040299549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZYVFGODM6FVUTNITA3Y33M7XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGI4TSNJUHE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago can you give an example of a page that doesn't work?
jamiereynolds1989
commented
7 months ago Literally majority, if not all that isn't in the category ''news''... some other categories display correctly, but the articles don't inside them, but in the ''news'' category, ALL articles display perfectly fine unless you click on one outside of ''news''
so he it works perfectly fine, other than elapsed time resetting: https://www.dailymail.co.uk/news/index.html
and these adjust a few examples that aren't displayed correctly whatsoever, other than the off category displaying fine: https://www.dailymail.co.uk/sport/football - this one says I'm in Sports but doesn't display any article I'm viewing like it does in ''News'', where in there it display thumbnail and article header perfectly, and it's like this for everywhere really other than in ''News'' like previously stated. So it just needs to be like it is in that category and it's perfect!
On Fri, Apr 5, 2024 at 10:17 PM ION606 @.***> wrote:
can you give an example of a page that doesn't work?
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040636526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ2WZQLR43G4K7LQT33Y34IFLAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGYZTMNJSGY . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago And then theres this: https://www.dailymail.co.uk/money/index.html which doesn't state I'm in ''Money'' and just says browsing news, so basically ''News'' works 100% of time flawlessly really and ''Sports'' displays category correctly and that's it, and others like 'Money'' aren't even displaying what category I'm in. Hopefully you can fix it cos if it'sall like the Nes category it's basically flawless! Probably one of most impressive presences outt there considering all the stuff on that website.
On Fri, Apr 5, 2024 at 10:24 PM Jamie Reynolds < @.***> wrote:
Literally majority, if not all that isn't in the category ''news''... some other categories display correctly, but the articles don't inside them, but in the ''news'' category, ALL articles display perfectly fine unless you click on one outside of ''news''
so he it works perfectly fine, other than elapsed time resetting: https://www.dailymail.co.uk/news/index.html
and these adjust a few examples that aren't displayed correctly whatsoever, other than the off category displaying fine: https://www.dailymail.co.uk/sport/football - this one says I'm in Sports but doesn't display any article I'm viewing like it does in ''News'', where in there it display thumbnail and article header perfectly, and it's like this for everywhere really other than in ''News'' like previously stated. So it just needs to be like it is in that category and it's perfect!
On Fri, Apr 5, 2024 at 10:17 PM ION606 @.***> wrote:
can you give an example of a page that doesn't work?
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040636526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ2WZQLR43G4K7LQT33Y34IFLAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGYZTMNJSGY . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago for the thumbnail, do you have the setting enabled in the extension, because it works for me
As for /money I never implemented it because every "money" link in the sitemap (found at https://www.dailymail.co.uk/home/sitemap.html) points to /yourmoney and the page you mentioned appears nowhere in there (see below image). I will try to add it as soon as I can :3
I'm still working on sports because every one of the 10+ categories has subcategories hmhm
ION606
commented
7 months ago also some of the sports articles seem to redirect to /article and some do not
jamiereynolds1989
commented
7 months ago Yeh its enabled. To be honest ''news'' and ''sports'' are the only two I use, same with my friends, I was just using ''Money'' as an example so if you could make ''sports'' articles work like it does in ''news'' that would be great as everything in News works great! No rush of course. I appreciate your time and help, really appreciated!
On Fri, Apr 5, 2024 at 10:38 PM ION606 @.***> wrote:
also some of the sports articles seem to redirect to /article and some do not
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040660805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZYOZED2ZGDD54BMG3DY34KW7AVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY3DAOBQGU . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago I'll try to have it done either today or tmw ^^ (the sport thing I mean)
jamiereynolds1989
commented
7 months ago You're the man! (or woman lol)
Thank you!
On Fri, Apr 5, 2024 at 11:02 PM ION606 @.***> wrote:
I'll try to have it done either today or tmw ^^ (the sport thing I mean)
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040685889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ4JIHO6IDXN6AONB3TY34NQPAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4DKOBYHE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago ueueueueueue man LMAO. Also, do you care if /money is displayed or not?
I ask bc I think I fixed the sports problem
ION606
commented
7 months ago also, how did actually GET to /money because I can't seem to find a way to get to it
jamiereynolds1989
commented
7 months ago https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago Sports is still the same fo rme, I attached pic, dno if you can see?
[image: image.png]
On Fri, Apr 5, 2024 at 11:16 PM Jamie Reynolds < @.***> wrote:
https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago Sport category and ''football ''premiere league'' sub categories are the main ones I would like to work properly.
At the min it says browsing sports: football for example
On Fri, Apr 5, 2024 at 11:17 PM Jamie Reynolds < @.***> wrote:
Sports is still the same fo rme, I attached pic, dno if you can see?
[image: image.png]
On Fri, Apr 5, 2024 at 11:16 PM Jamie Reynolds < @.***> wrote:
https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago ok so some sub categories in ''sport'' are working fine but no thumbnail, but ''football'' isnt yet
On Fri, Apr 5, 2024 at 11:19 PM Jamie Reynolds < @.***> wrote:
Sport category and ''football ''premiere league'' sub categories are the main ones I would like to work properly.
At the min it says browsing sports: football for example
On Fri, Apr 5, 2024 at 11:17 PM Jamie Reynolds < @.***> wrote:
Sports is still the same fo rme, I attached pic, dno if you can see?
[image: image.png]
On Fri, Apr 5, 2024 at 11:16 PM Jamie Reynolds < @.***> wrote:
https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago Btw, tiem elapsed is still broken, so maybe it's best to just remove it completely? Not really useful anyway.
On Fri, Apr 5, 2024 at 11:22 PM Jamie Reynolds < @.***> wrote:
ok so some sub categories in ''sport'' are working fine but no thumbnail, but ''football'' isnt yet
On Fri, Apr 5, 2024 at 11:19 PM Jamie Reynolds < @.***> wrote:
Sport category and ''football ''premiere league'' sub categories are the main ones I would like to work properly.
At the min it says browsing sports: football for example
On Fri, Apr 5, 2024 at 11:17 PM Jamie Reynolds < @.***> wrote:
Sports is still the same fo rme, I attached pic, dno if you can see?
[image: image.png]
On Fri, Apr 5, 2024 at 11:16 PM Jamie Reynolds < @.***> wrote:
https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago time elapsed works fine for me, I suspect it's an issue on your end but I can add a toggle for that if you want, also see https://github.com/PreMiD/Presences/pull/8251/ for updates on the sports article fix :3
jamiereynolds1989
commented
7 months ago Literally every sub category in Sports works fine and dispalyin the header but the thumbnail for the article isn't working as of now, and the only one that isn't workin at all is ''Football'' lol (jsut sayings browsing sports/football)
On Fri, Apr 5, 2024 at 11:24 PM Jamie Reynolds < @.***> wrote:
Btw, tiem elapsed is still broken, so maybe it's best to just remove it completely? Not really useful anyway.
On Fri, Apr 5, 2024 at 11:22 PM Jamie Reynolds < @.***> wrote:
ok so some sub categories in ''sport'' are working fine but no thumbnail, but ''football'' isnt yet
On Fri, Apr 5, 2024 at 11:19 PM Jamie Reynolds < @.***> wrote:
Sport category and ''football ''premiere league'' sub categories are the main ones I would like to work properly.
At the min it says browsing sports: football for example
On Fri, Apr 5, 2024 at 11:17 PM Jamie Reynolds < @.***> wrote:
Sports is still the same fo rme, I attached pic, dno if you can see?
[image: image.png]
On Fri, Apr 5, 2024 at 11:16 PM Jamie Reynolds < @.***> wrote:
https://www.dailymail.co.uk/home/index.html all the categories are at the top for me and no i don't care about money, the only two I really use are News And Sports and the subcategories inside those [image: image.png]
On Fri, Apr 5, 2024 at 11:12 PM ION606 @.***> wrote:
also, how did actually GET to /money because I can't seem to find a way to get to it
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040696321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3GGJHDQURED5R3MSDY34OWRAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGY4TMMZSGE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago yer the fix at https://github.com/PreMiD/Presences/pull/8251/ should take care of that (I hope)
jamiereynolds1989
commented
7 months ago yeh so they all work in sports other than footbal and premiere league, but not thumbnails. do thee fixes have to be manually approved by someone or something? I don't understand it at all lol but you've improved it so much more already so that's great!
On Fri, Apr 5, 2024 at 11:28 PM ION606 @.***> wrote:
yer the fix at #8251 https://github.com/PreMiD/Presences/pull/8251 should take care of that (I hope)
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040709851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3LFFRPAN3YKL7S5O3Y34QQHAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YDSOBVGE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago for example, this link will now look like this
also yes, two reviewers have to approve the changes before they can be merged into the repo
jamiereynolds1989
commented
7 months ago Is this when its approved, cos its not at the moment
can u see attached pictures im sending by the way?
[image: image.png] [image: image.png]
On Fri, Apr 5, 2024 at 11:31 PM ION606 @.***> wrote:
for example, this link https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html will now look like this image.png (view on web) https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3
also yes, two reviewers have to approve the changes before they can be merged into the repo
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago and it says ''browsing [insert category here'' for me and not reading article like in your picture, i think it showing the category then the headline of the article under it like it currently does is best way to go about it. let me know when the football and premiere league sub categories are working like the rest, all the rest working fine(other than thumbnail as stated) thanks again!
On Fri, Apr 5, 2024 at 11:42 PM Jamie Reynolds < @.***> wrote:
Is this when its approved, cos its not at the moment
can u see attached pictures im sending by the way?
[image: image.png] [image: image.png]
On Fri, Apr 5, 2024 at 11:31 PM ION606 @.***> wrote:
for example, this link https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html will now look like this image.png (view on web) https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3
also yes, two reviewers have to approve the changes before they can be merged into the repo
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE . You are receiving this because you authored the thread.Message ID: @.***>
jamiereynolds1989
commented
7 months ago in fact either are fine, as long as it shows the article headline thats main thing to me.
On Fri, Apr 5, 2024 at 11:46 PM Jamie Reynolds < @.***> wrote:
and it says ''browsing [insert category here'' for me and not reading article like in your picture, i think it showing the category then the headline of the article under it like it currently does is best way to go about it. let me know when the football and premiere league sub categories are working like the rest, all the rest working fine(other than thumbnail as stated) thanks again!
On Fri, Apr 5, 2024 at 11:42 PM Jamie Reynolds < @.***> wrote:
Is this when its approved, cos its not at the moment
can u see attached pictures im sending by the way?
[image: image.png] [image: image.png]
On Fri, Apr 5, 2024 at 11:31 PM ION606 @.***> wrote:
for example, this link https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html will now look like this image.png (view on web) https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3
also yes, two reviewers have to approve the changes before they can be merged into the repo
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago Is this when its approved, cos its not at the moment can u see attached pictures im sending by the way? [image: image.png] [image: image.png] … On Fri, Apr 5, 2024 at 11:31 PM ION606 @.> wrote: for example, this link https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html will now look like this image.png (view on web) https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3 also yes, two reviewers have to approve the changes before they can be merged into the repo — Reply to this email directly, view it on GitHub <#7600 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE . You are receiving this because you authored the thread.Message ID: @.>
no, it is not approved and no I can not see your images, maybe it's bc you're responding by email? I'm not sure.
jamiereynolds1989
commented
7 months ago yeh I'm responding by email, that will be why then. so when it's approved the thumbnails will show and the football and premiere league category will show article headlines, like the rest of the suv categories under sports do, correct?
On Fri, Apr 5, 2024 at 11:52 PM ION606 @.***> wrote:
Is this when its approved, cos its not at the moment can u see attached pictures im sending by the way? [image: image.png] [image: image.png] … <#m7562439569560598504> On Fri, Apr 5, 2024 at 11:31 PM ION606 @.> wrote: for example, this link https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html https://www.dailymail.co.uk/sport/football/article-13275599/Sergio-Agueros-iconic-title-winning-goal-Man-City-Newcastles-incredible-comeback-four-goals-against-Arsenal-10-BONKERS-Premier-League-matches-Man-Uniteds-collapse-Chelsea.html will now look like this image.png (view on web) https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3 https://github.com/PreMiD/Presences/assets/58801387/90d44ba0-baad-437b-8564-16c3078744f3 also yes, two reviewers have to approve the changes before they can be merged into the repo — Reply to this email directly, view it on GitHub <#7600 (comment) https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE https://github.com/notifications/unsubscribe-auth/AZE5IZ3QC66XOG5W54NT6TTY34Q3XAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4YTEMBXGE . You are receiving this because you authored the thread.Message ID: @.>
no, it is not approved and no I can not see your images, maybe it's bc you're responding by email? I'm not sure.
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040731711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ4HZ5GXHLYKEVWBONDY34TKHAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4ZTCNZRGE . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago it should look like the image I provided in https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071 when it's approved.
jamiereynolds1989
commented
7 months ago yeh that looks good too, looks good to me ^_^
On Fri, Apr 5, 2024 at 11:55 PM ION606 @.***> wrote:
it should look like the image I provided in #7600 (comment) https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040712071 when it's approved.
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040734652, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ7GJLMWDTCEU5IKLMDY34TXPAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG4ZTINRVGI . You are receiving this because you authored the thread.Message ID: @.***>
ION606
commented
7 months ago @jamiereynolds1989 I pushed a fix for the timestamp issue so hopefully that shouldn't be a problem ^^
jamiereynolds1989
commented
7 months ago everything is still the same for me at the moment? no thumbnails in sports, or article header and resetting of time elapsed. Does it need approving again first before it takes effect?
On Sat, Apr 6, 2024 at 6:04 AM ION606 @.***> wrote:
@jamiereynolds1989 https://github.com/jamiereynolds1989 I pushed a fix for the timestamp issue so hopefully that shouldn't be a problem ^^
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2040968080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZZUADTYBH7VF43VVPDY3567LAVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHE3DQMBYGA . You are receiving this because you were mentioned.Message ID: @.***>
ION606
commented
7 months ago yea there seems to be smth wrong with github (it's returning 520) I'm waiting for someone to re-run github actions
jamiereynolds1989
commented
7 months ago Ok, thanks for the update.
On Sat, Apr 6, 2024 at 2:13 PM ION606 @.***> wrote:
yea there seems to be smth wrong with github (it's returning 520) I'm waiting for someone to re-run github actions
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2041079073, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ6EDTI2FXRE4KTIS4TY37YI7AVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGA3TSMBXGM . You are receiving this because you were mentioned.Message ID: @.***>
jamiereynolds1989
commented
7 months ago any update?
On Sat, Apr 6, 2024 at 5:28 PM Jamie Reynolds < @.***> wrote:
Ok, thanks for the update.
On Sat, Apr 6, 2024 at 2:13 PM ION606 @.***> wrote:
yea there seems to be smth wrong with github (it's returning 520) I'm waiting for someone to re-run github actions
— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/issues/7600#issuecomment-2041079073, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE5IZ6EDTI2FXRE4KTIS4TY37YI7AVCNFSM6AAAAAA4ABTOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGA3TSMBXGM . You are receiving this because you were mentioned.Message ID: @.***>
ION606
commented
7 months ago any update?
On Sat, Apr 6, 2024 at 5:28 PM Jamie Reynolds <
@.***> wrote:
Ok, thanks for the update.
On Sat, Apr 6, 2024 at 2:13 PM ION606 @.***> wrote:
yea there seems to be smth wrong with github (it's returning 520) I'm
waiting for someone to re-run github actions
—
Reply to this email directly, view it on GitHub
https://github.com/PreMiD/Presences/issues/7600#issuecomment-2041079073,
or unsubscribe
.
You are receiving this because you were mentioned.Message ID:
@.***>
still waiting for review ;-;
ION606
commented
7 months ago it's been merged, please give 15 mins or so for the changes to take effect @jamiereynolds1989
Website name
DailyMail
Website URL
www.dailymail.co.uk
Website logo
https://www.google.com/search?q=daily+mail+logo&source=lmns&bih=652&biw=412&client=ms-android-samsung&hl=en&sa=X&ved=2ahUKEwjhisiWg_yAAxVbnCcCHVaJAesQ0pQJKAB6BAgAEAc#vhid=2LjJ4gpiuv2gxM&vssid=l
Prerequisites
Description
I think this news paper website would be a massive add on for your amazing premid service as it's one if the biggest not only in the UK but world wide. Please add it, it would.be absolutely amazing!
Keep up the good work!