search

PreTeXtBook / pretext-cli

Command line interface for quickly creating, authoring, and building PreTeXt documents.
https://pretextbook.org
GNU General Public License v3.0
17 stars 18 forks source link

at least warn authors who are working in an absolute filepath with spaces #187

Closed StevenClontz closed 2 years ago

StevenClontz commented 2 years ago

At the least, publication files cannot be imported if anywhere in the absolute filepath has spaces

rbeezer commented 2 years ago

This is an XSLT problem it seems. The percent-encoding of a space (%20) can happen when XSL receives the filename as a string (stringparam) and before its use in a document() function to actually read the file. Fix tested with the publisher file, and there are at least three other files.

Working on it and will post here once complete.

rbeezer commented 2 years ago

Fix is in at https://github.com/rbeezer/mathbook/commit/8dfbdff1a43e9096134d2b2eb7ebdabfac40f130

You might read the code comments in that commit for a bit of perspective, should this become evermore subtler than it is already. ;-)

StevenClontz commented 2 years ago

Reopening until I have a chance to update CLI and make sure this is working now

StevenClontz commented 2 years ago

Can confirm spaces in the publication filename don't choke things as of this core commit update. https://github.com/PreTeXtBook/pretext-cli/commit/094db808babe36d700182a236fc0cc0c2355437a