PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
267 stars 209 forks source link

URLs in note in biblio don't appear #1990

Closed kcrisman closed 1 year ago

kcrisman commented 1 year ago

The "note" tag ordinarily seems to be a REMARK-LIKE object, except when it's inside a "biblio". However, that means it still gets "caught" (I think) by things like &REMARK-FILTER and this causes an issue in a specific place, which is a url tag in the note of a biblio. As a result, we get a \footnotemark{} in LaTeX and not a full footnote. If I'm interpreting https://github.com/PreTeXtBook/pretext/blob/master/xsl/pretext-latex.xsl#L10535 correctly. In HTML we seem to get the footnote fine.

kcrisman commented 1 year ago

I think I can fairly easily exclude that particular case by amending the xsl:when at https://github.com/PreTeXtBook/pretext/blob/master/xsl/pretext-latex.xsl#LL10537C117-L10537C131 but would appreciate any comment on whether there is a preferred "slicker" or "PTX-style" way to do that before I go ahead and try something out.

rbeezer commented 1 year ago

Good catch. Yes, we need to do fancy footwork to get footnotes out of tcolorbox (REMARK-LIKE), one of which is note. Not clear to me why we are only getting half of what we need, though. Give me a couple days to investigate before we agree on a course of action.

kcrisman commented 1 year ago

Thanks. I'd appreciate any thoughts, because I need to fix this before releasing a new edition, and I should (hopefully?) be able to figure it out if you give a pointer for how not to create chaos 😄

rbeezer commented 1 year ago

It was a bit of a delicate fix, so I just went ahead and did it, since the absence of "the other half" of the footnote was a bit baffling at first. One line of code and 8 or so lines of comments.; ;-) 50dffb67a4b54987f6cc35d223ab0123969cf383

Two new footnotes in the sample article (as suggested on unrelated thread!) which will go live on the website in the next 24-48 hours. 6cc87da5633300854c3bdc9f25812cd37cec0633

Thanks! That was a subtle one, and your diagnosis was spot-on. Have I mentioned how much I despise footnotes?

kcrisman commented 1 year ago

Thanks! That was a subtle one, and your diagnosis was spot-on. Have I mentioned how much I despise footnotes?

Thank YOU. Not sure I could live without footnotes ...

kcrisman commented 1 year ago

@rbeezer followup: In line 803 of pretext-assembly we have

<fn pi:url="{$truncated-href}"/>

for the gratis footnote that appears. However, in some recent discussion (which I couldn't find on -support or -dev since Google search on groups apparently isn't that great) there was discussion about how we don't want footnotes in these URLs. Currently they do produce footnotes (not just marks) which however do not appear (as to which see https://tex.stackexchange.com/questions/23157/footnote-to-a-footnote).

I think we do not even want footnote marks in this case, but personally believe URLs should be allowed in footnotes. I think the assembly step is the right place to remove these footnote steps.

rbeezer commented 1 year ago

Follow-up is #1998, implemented in #1999.