search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
264 stars 206 forks source link

missing "open problem filter" in footnotes #2009

Closed kcrisman closed 1 year ago

kcrisman commented 1 year ago

pretext-latex.xsl has a match for &COMPUTATION-LIKE;|&OPENPROBLEM-LIKE;|&EXAMPLE-LIKE; (among other things) in footnotes, but the open problem piece is missing in the immediately following line, or &COMPUTATION-FILTER; or &EXAMPLE-FILTER;.

Since everything else in those lines is repeated very precisely, is it okay to presume this was an inadvertent miss and can be provided? Alternately, since open problem is also missing from the earlier template, maybe having open problem is an error.

In either case, I'm happy to provide the fix.

rbeezer commented 1 year ago

Yes, certainly an omission. I think I was doing open problems with a search on some other *-LIKE to see what to change, and forgot to also search on *-FILTER. And I always forget this is a two-part drill - the mark and the content.

Yes, a fix would be welcome!

And maybe add a footnote to an example in teh sample article, to make sure it continues to behave.

Thanks for catching this. Are you using these new blocks?

rbeezer commented 1 year ago

Fixed at 9322c1f6305e13b4a55d81f9397b1c206ffc6485. Thanks very much for the catch.

I had to add an example of an openproblem to the sample article before I could even begin to fix this! Eventually, I should add in a bunch of examples that @davidfarmer has been working up for testing.