search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
254 stars 202 forks source link

Latexmode #2112

Closed Alex-Jordan closed 3 months ago

Alex-Jordan commented 3 months ago

Two commits here. The first just updates a couple of project.ptx files. Without these changes, the CLI croaks when trying to build these two projects. Discovered while trying to use minimal example in testing the following.

Today a user asked about something which led me to realize: if your system does not have a certain latex package, and if that package is loaded in your latex-image-preamble, then when pretext tries to make images, of course it fails to find that package. This is not considered a latex compilation error that would make latex compilation stop (since we use -halt-on-error). Rather, this causes a prompt asking for the user to try entering a path for the missing package. I don't know where that prompt goes, but it does not go to the pretext user's terminal. So in the end, it just seems like pretext is stalling out. Really, it's waiting for input that will never come.

So I added nonstopmode. Shouldn't change anything when an actual error is hit, because -halt-on-error will halt the compilation. But nonstopmode also causes the job to abort when a package file is missing. So now it's clear to the user something went bad. A user can run in a verbose debugging mode to get more information about exactly what.

rbeezer commented 3 months ago

Nice. Especially since we raise a Python error:

ValueError: LaTeX compilation failed for 23 "latex-image"(s).

Perhaps the CLI (@oscarlevin, @StevenClontz) will want to catch this, if they are not already.

rbeezer commented 3 months ago

Done. Great improvement. Thanks.