search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
254 stars 202 forks source link

Pretext-webwork knowl update #2121

Closed ascholerChemeketa closed 3 months ago

ascholerChemeketa commented 3 months ago

Changes pretext-webwork to use summary/detail born hidden knowls instead of id-ref based knowls. This change enables removal of id-ref related code from knowl.js.

Am only able to test against Tested against 2.17 using: https://pretextbook.org/examples/webwork/sample-chapter/html/sample-ww-chapter-4-2.html#using-hints But the code replaced appears to be identical across 2.16/2.17/2.18

Unblocks https://github.com/PreTeXtBook/pretext/pull/2109

@Alex-Jordan

Alex-Jordan commented 3 months ago

I can double check on things next week, but I have faith you have this right.

Can you say a word about the iframeResizer change?

ascholerChemeketa commented 3 months ago

The lowestElement setting appears to reserve future space for the summary. That leaves a long gap after the titles: image

min only accounts for the spaces used by the titles themselves: image

When you expand them, the available space is increased appropriately: image

rbeezer commented 3 months ago

Very good! (Removed three stray tabs.) Merged. Thanks.