PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
254 stars 202 forks source link

Knowl format cleanup #2134

Closed ascholerChemeketa closed 2 months ago

ascholerChemeketa commented 2 months ago

Still a draft. Generating PR so @rbeezer can check out the xsl.

rbeezer commented 2 months ago

I think the XSL looks real good at first blush.

ascholerChemeketa commented 2 months ago

@davidfarmer @rbeezer

OK, I think this is ready for real review.

Comments: Born Hidden and XRef knowls both get underlined and have same color. XRef links get the same color as external links and no underline to clearly distinguish that they are links and not knowls.

This does not restore the color stripes that prior to details/summary were on the left side of some born hidden's. IMO those decorations should wait for a deeper dive on color themes & dark mode - hard coding in specific colors complicates those efforts

Born Hidden's have the triangle marker as that is what they looked like even before the details switch. XRef knowls do not. It would not be hard to add triangle markers to them if that was desired. It does nicely communicate that they open something up. But, it can look a little weird when the thing opening up is further down the page.

rbeezer commented 2 months ago

Excellent! Repackaged commits, but otherwise as-is. Thanks for working through this one!