search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
268 stars 210 forks source link

FITB: correct attributes on fillins relating to static representation #2239

Closed dbrianwalton closed 3 months ago

dbrianwalton commented 3 months ago

Addresses the wrong reference in the fillin that should be a cubic (was referencing the wrong object) and fixes @mode for fillins that were supposed to be math so that the LaTeX was within <m>.

rbeezer commented 3 months ago

Thanks for updating these. I repackaged this as two commits, one for each sample document.

The "substitutions" file is unchanged? I re-generated it and formed a diff, but that was not helpful to me. Seems like the one currently in the repository has been re-formatted? I get a new version with no line breaks (which is fine, since it is not meant to be human-readable). But the diff is worthless.

dbrianwalton commented 3 months ago

The second PR that deals with ability to do reductions and simplifications will have some changes to the substitutions.

On Mon, Aug 12, 2024 at 1:18 PM Rob Beezer @.***> wrote:

Thanks for updating these. I repackaged this as two commits, one for each sample document.

The "substitutions" file is unchanged? I re-generated it and formed a diff, but that was not helpful to me. Seems like the one currently in the repository has been re-formatted? I get a new version with no line breaks (which is fine, since it is not meant to be human-readable). But the diff is worthless.

— Reply to this email directly, view it on GitHub https://github.com/PreTeXtBook/pretext/pull/2239#issuecomment-2284540720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARCEJM3ZT6ZOFJN47TPE3TZRDU5FAVCNFSM6AAAAABLWTZFUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGU2DANZSGA . You are receiving this because you authored the thread.Message ID: @.***>

rbeezer commented 3 months ago

Thanks. Going there now.