PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
268 stars 210 forks source link

Program update / add missing features #2298

Open ascholerChemeketa opened 6 days ago

ascholerChemeketa commented 6 days ago

I believe this is ready for review. I just rebased to master and regrouped commits.

Testing is going to be fun as this requires new Runestone code (https://github.com/RunestoneInteractive/rs/pull/582) and some of it only works on a Runestone server.

ascholerChemeketa commented 4 days ago

@bnmnetp merged https://github.com/RunestoneInteractive/rs/pull/582

This should be ready for testing PTX side.

bnmnetp commented 4 days ago

I merged, but I have not yet created a new runestone release. I will do that tomorrow.

bnmnetp commented 3 days ago

runestone 7.4.6 is now out.

rbeezer commented 12 hours ago

The organization here is improved - thanks. I think (based on not much care) that the "view source" stuff should have been an independent, or later, PR.

A refactor needs to clearly make no changes in output. It looks to me like I should be able to checkout the "Deprecate and fix program/input" commit and there should be no changes to the output of the samples. (Yes?)

LaTeX output, both sample book and sample article, show many hunks of code going missing. Some appear to be inside solution to exercises. I didn't investigate further, but maybe a static version of a Parsons programming exercise provides a solution which is not yet migrated from input to code?

If changes are needed, please rebase them into the commits you already have and force-push. I've got about an hour invested in understanding the current organization and don't want that to change.

rbeezer commented 11 hours ago

On an HTML comparison with the sample book, I'm seeing what looks like some sort of datafile stuff coming though totally unwrapped by anything. For example (meaningless line breks added for clarity):

<div class="para" id="data-files-2">In the following file of climate data, the first column 
is Year, second column is Global Average Temperature (Celcius), and the third column
 is Global Emmisions C02 (Giga-tons).  [Normally you might place this inside a block 
with the <code class="code-inline tex2jax_ignore">&lt;datafile&gt;</code>.]</div>

            1850    -0.37     2.24E-7
            1860    -0.34     3.94E-7
            1870    -0.28     6.6E-7
            1880    -0.24     1.1
            ...
ascholerChemeketa commented 11 hours ago

Will go check into those.

Just to clarify... I should make any new commits be fixups to the existing ones? Or do you want the new commits to be individual commits and just reordered into the existing sequence?

rbeezer commented 10 hours ago

I should make any new commits be fixups to the existing ones?

Yes, meld additions into current organization, no new commits. Force push once ready-to-go. Thanks.

ascholerChemeketa commented 9 hours ago

There was indeed a bug in constructing the program text for latex.

Did a force push that changed 58f7ca1 - Static representations use code instead of input and include visible pre/postambles

The datafile issue was due to some "view-source" related code that got accidentally separated up into different commits (that were on either side of the commit you were looking at). I moved the code that accidently got included in an early commit to with the rest of the view-source stuff.

rbeezer commented 4 hours ago

Thanks for the updates. May be offline tomorrow after Drop-In (contractors), but I'll try to get to this ASAP.