PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

WeBWorK table border warning message #397

Closed Alex-Jordan closed 7 years ago

Alex-Jordan commented 8 years ago

This warning is produced during xsltproc processing every time it is relevant:

MBX:WARNING: medium and major will come out as minor in the hardcopy output of a WeBWorK PG table

I think we could change things so it just gets printed one time, instead of hundreds. It's going to be a very common warning in a book with lots of WeBWorK.

rbeezer commented 8 years ago

I've thought exactly the same.

Do you see the place at the bottom of xsl/mathbook-common.xsl where one-time warnings are issued? Can you mimic such a setup in mathbook-latex.xsl?

On 09/19/2016 04:31 PM, Alex Jordan wrote:

This warning is produced during xsltproc processing every time it is relevant:

|MBX:WARNING: medium and major will come out as minor in the hardcopy output of a WeBWorK PG table |

I think we could change things so it just gets printed one time, instead of hundreds. It's going to be a very common warning in a book with lots of WeBWorK.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/397, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cuSoZvlpHNPiCFTsM9Vndar--nDdks5qrxtpgaJpZM4KBEzg.

Alex-Jordan commented 8 years ago

So I would add a one-time error to mathbook-common, and remove the warning from mathbook-webwork-pg, right? Not sure how mathbook-latex is involved.

rbeezer commented 8 years ago

I was taking "hardcopy" to suggest LaTeX output. But I guess a WW problem may be printed by a student from a server where it may have migrated from an archive, so we could warn on every conversion (this in -common).

Alex-Jordan commented 8 years ago

To me, "hardcopy" is WeBWorK vocab for when a student prints a homework set from within WeBWorK. MBX latex output is different.

If a problem is authored in an MBX book, it will see use in a WeBWorK hardcopy eventually. Even if you are teaching the course and using the MBX book, some students will print a hardcopy of an assignment if you assign through WeBWorK.

Alex-Jordan commented 7 years ago

Addressing this in my current spate of WeBWorK related issues. I've got it to give a single warning message that includes a count of how many instances there are, but doesn't give location information.

I'm inclined to only print these warnings when mathbook-webwork-archive.xsl is used, because that produces the .pg files that might end up on a WeBWorK server, that might get pushed through WeBWorK's hardcopy production machine, and lead to the discrepancies these warnings are referring to.

Alternatively, I could print the warnings from mathbook-common.xsl and you'd see them all the time. Preference?

This is all predicated on my other work that isolates server-based png image scraping from server-based tex scraping. In other words, if you have authored a table in MBX source, then with MBX HTML and print output, that table will be rendered using MBX constructs, not say WeBWorK-generated tex. This is true even if elsewhere in the problem you are using a WeBWorK-generated png image.

rbeezer commented 7 years ago

Thanks for this. I'd like to warn in mathbook-common.xsl as much as possible

With a one-time warning and a count, there is no point to have location information. Discovered early, an author should know where the bodies lie.

Rob

On 11/23/2016 12:01 PM, Alex Jordan wrote:

Addressing this in my current spate of WeBWorK related issues. I've got it to give a single warning message that includes a count of how many instances there are, but doesn't give location information.

I'm inclined to only print these warnings when |mathbook-webwork-archive.xsl| is used, because that produces the |.pg| files that might end up on a WeBWorK server, that might get pushed through WeBWorK's hardcopy production machine, and lead to the discrepancies these warnings are referring to.

Alternatively, I could print the warnings from |mathbook-common.xsl| and you'd see them all the time. Preference?

This is all predicated on my other work that isolates server-based png image scraping from server-based tex scraping. In other words, if you have authored a table in MBX source, then with MBX HTML and print output, that table /will/ be rendered using MBX constructs, not say WeBWorK-generated tex. This is true even if elsewhere in the problem you are using a WeBWorK-generated png image.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/397#issuecomment-262617136, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cj48V57vtCiTBd7wQTpIg0Lgecg4ks5rBJuvgaJpZM4KBEzg.

Alex-Jordan commented 7 years ago

mathbook-webwork-archive does not call the common generic-warnings template. Should I make it so? Or only make it call the new generic webwork warnings template?

rbeezer commented 7 years ago

Yes, lets have mathbook-webwork-archive call the generic-warnings template.

Is there a need for a "generic webwork warnings" template? Can they not go in the generic one? I'd rather not have these proliferate too much.

Mostly, quality of source is independent of choice of output format.

On 11/23/2016 01:03 PM, Alex Jordan wrote:

|mathbook-webwork-archive| does not call the common generic-warnings template. Should I make it so? Or only make it call the new generic webwork warnings template?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/397#issuecomment-262629392, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cqrPKpyobgJbLi5cWc0OW_wirR09ks5rBKotgaJpZM4KBEzg.

Alex-Jordan commented 7 years ago

OK, sounds good.

What I meant was, what is currently

<xsl:template match="mathbook" mode="generic-warnings">
    <xsl:apply-templates select="." mode="xinclude-warnings" />
    <xsl:apply-templates select="." mode="xmlid-warning" />
</xsl:template>

is now going to be

<xsl:template match="mathbook" mode="generic-warnings">
    <xsl:apply-templates select="." mode="xinclude-warnings" />
    <xsl:apply-templates select="." mode="xmlid-warning" />
    <xsl:apply-templates select="." mode="webwork-warnings" />
</xsl:template>

with webwork-warnings defined below. Right now there are three warnings all related to tables. If you'd prefer, I could name it webwork-table-warnings or something like that.

rbeezer commented 7 years ago

I did take a look at this. ;-) But not carefully enough.

Yes, that list of two can become a list of three. That'll be good.

I didn't want the more specific templates (-html, -latex, etc) to have a long list of these.

On 11/23/2016 01:33 PM, Alex Jordan wrote:

OK, sounds good.

What I meant was, what is currently

| <xsl:apply-templates select="." mode="xinclude-warnings" /> <xsl:apply-templates select="." mode="xmlid-warning" /> /xsl:template |

is now going to be

| <xsl:apply-templates select="." mode="xinclude-warnings" /> <xsl:apply-templates select="." mode="xmlid-warning" /> <xsl:apply-templates select="." mode="webwork-warnings" /> /xsl:template |

with |webwork-warnings| defined below. Right now there are three warnings all related to tables. If you'd prefer, I could name it |webwork-table-warnings| or something like that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/397#issuecomment-262635215, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cm9DnXTTP9hLKHuDO-_sy8pToKp4ks5rBLEjgaJpZM4KBEzg.

rbeezer commented 7 years ago

438 takes care of this one.