PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

colsN with list #588

Closed davidfarmer closed 7 years ago

davidfarmer commented 7 years ago

colsN is not functioning as desired when applied to a list. For example:

https://cdn.rawgit.com/byoshiwara/mfg/master/LinMod.html

List in Exercise 29 (near bottom of page, look for "intercepts of the graph for each equation") has c below b

and http://mathbook.pugetsound.edu/examples/humanities/html/chords.html Example2.4.1Chords has blank space in columns.

In both cases, the colsN class on the ol has no effect on the layout, and the widths and floats of the li elements are hard coded into the HTML.

The CSS for colsN, which I think works properly when it applies, seems to only be for exercise-like articles in an exercise or exercisegroup.

I am guessing we can make this work properly once we decide what things can be colsN, and how to mark up the HTML.

Alex-Jordan commented 7 years ago

colsN came into existence with exercisegroup and columns. Look there for the structure where it is working. With regular lists like the issues here, I think we need to establish if we really want the HTML to be ol with li's, or if we want to hard code our numbering and use something else besides ol and li's. There are pros and cons to either. One pro to not using ol/li is that these kinds of lists could be built just like the exercisegroup exercises.

On Fri, May 26, 2017 at 6:33 AM, davidfarmer notifications@github.com wrote:

colsN is not functioning as desired when applied to a list. For example:

https://cdn.rawgit.com/byoshiwara/mfg/master/LinMod.html

List in Exercise 29 (near bottom of page, look for "intercepts of the graph for each equation") has c below b

and http://mathbook.pugetsound.edu/examples/humanities/html/chords.html Example2.4.1Chords has blank space in columns.

In both cases, the colsN class on the ol has no effect on the layout, and the widths and floats of the li elements are hard coded into the HTML.

The CSS for colsN, which I think works properly when it applies, seems to only be for exercise-like articles in an exercise or exercisegroup.

I am guessing we can make this work properly once we decide what things can be colsN, and how to mark up the HTML.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/588, or mute the thread https://github.com/notifications/unsubscribe-auth/AEg3AFNzZK1UwaNXproTkqW1TBi4-xyzks5r9tTAgaJpZM4NnmxO .

-- Alex Jordan Mathematics Instructor Portland Community College

Alex-Jordan commented 7 years ago

Perhaps this is a solution the colsN issue that is in Bruce's example David linked to.

http://jsfiddle.net/PUQNg/477/

I tested for Firefox, Safari, and Chrome and it worked. I'm not sure how to best set width and margin-left though.

If the screen becomes small, less than ideal behavior is observed with cols3.

rbeezer commented 7 years ago

I think I have Bruce's example, or similar, on a branch.

Happy to add that to sample article, and/or adjust HTML to suit a new approach.

davidfarmer commented 7 years ago

Also see the solution to the first exercise here:

https://community.plu.edu/~sklarjk/ptx/ptx/appendix-1.html

davidfarmer commented 7 years ago

Probably I fixed this, but we need to revisit the HTML markup. (The cords and Bruce's example are fixed. Waiting to check on other examples.)

I don't think I am against using ol/ul and li, but it makes no sense to hard-code the width and float of each li. If that is the right way to do it, then do it in CSS.

davidfarmer commented 7 years ago

Closing, but maybe there should be a new issue about the HTML markup of colsN lists

rbeezer commented 7 years ago

Any hard-coded "style=" was generally a way to get "things" working quickly.

I think "list-item-style" is the one thing you must do with a @style attribute and cannot do with CSS.

Widths in "sidebyside" are hard-coded. Since allowed to be non-uniform, I don't see a good solution for that case.

On 08/02/2017 04:03 PM, davidfarmer wrote:

Probably I fixed this, but we need to revisit the HTML markup. (The cords and Bruce's example are fixed. Waiting to check on other examples.)

I don't think I am against using ol/ul and li, but it makes no sense to hard-code the width and float of each li. If that is the right way to do it, then do it in CSS.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/588#issuecomment-319822484, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2crkpVOsz083pMdqGV6cUhNRUgZz8ks5sUQBYgaJpZM4NnmxO.