search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

WW exercises should be in hidded-knowl-wrapper s #615

Closed davidfarmer closed 7 years ago

davidfarmer commented 7 years ago

The WW exercises on this page:

http://mathbook.pugetsound.edu/examples/webwork/sample-chapter/html/section-11.html

are in bare div's. Those div's should have class="hidden-knowl-wrapper"

rbeezer commented 7 years ago

Right. Good catch. A WW problem in an embedded knowl (which is what these are in the general structure of producing knowlized content) would not render.

So I had put in a hack to realize these as external-file knowls. That results in the bare divs, absence of "hidden-knowl-wrapper", etc. I should know better than to cut corners.

So I unwound the hack and I think all the CSS is now working right. But the knowl does not.

@Alex-Jordan will need to know.

rbeezer commented 7 years ago

It is possible I could move the hack more interior. In other words, not so many changes to the surroundings, just change the a tag.

Does the styling depend on any aspects of the a tag which is the actual knowl link?

rbeezer commented 7 years ago

Forgot to include the relevant commit. cf0f943c

rbeezer commented 7 years ago

I restored the hack, but only changed the anchor tag, so the WW exercise is being served from an external file, not an embedded knowl.

@Alex-Jordan please check that you like the formatting now.

I'm closing this, since the styling problems are solved, and moving it to a more general issue.

See https://github.com/rbeezer/mathbook/issues/629

Alex-Jordan commented 7 years ago

The layout issue is addressed. I'll alert Matt to rebuild HTML for Active Calculus.

rbeezer commented 7 years ago

Thanks for checking.

On 07/13/2017 02:38 PM, Alex Jordan wrote:

The layout issue is addressed. I'll alert Matt to rebuild HTML for Active Calculus.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/615#issuecomment-315209420, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2coDWxg09-qmTxJhV8nppmqug9l8Rks5sNo5ggaJpZM4OQz9t.