PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

Empty title in assemblage #728

Closed davidfarmer closed 7 years ago

davidfarmer commented 7 years ago

In the small assemblage immediately above Section 4.6 in the sample article:

http://mathbook.pugetsound.edu/examples/sample-article/html/interesting-corollary.html

There is an h5.heading containing only an empty span.title . This causes issues with the layout.

rbeezer commented 7 years ago

When the title is empty, I'll delete the "span". Should the "h5.heading" go away entirely then?

On 09/21/2017 03:25 PM, David W. Farmer wrote:

In the small assemblage immediately above Section 4.6 in the sample article:

http://mathbook.pugetsound.edu/examples/sample-article/html/interesting-corollary.html

There is an h5.heading containing only an empty span.title . This causes issues with the layout.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/728, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cjctQH0K_A_3uD4A2NBBnbYxM1o0ks5skuJWgaJpZM4Pf_uR.

rbeezer commented 7 years ago

The template doing this is also used for aside (presently title optional) and paragraphs (eventually title required).

davidfarmer commented 7 years ago

Yes, we also don't want and empty .heading.

On Thu, 21 Sep 2017, Rob Beezer wrote:

When the title is empty, I'll delete the "span". Should the "h5.heading" go away entirely then?

On 09/21/2017 03:25 PM, David W. Farmer wrote:

In the small assemblage immediately above Section 4.6 in the sample article:

http://mathbook.pugetsound.edu/examples/sample-article/html/interesting-corollary.html

There is an h5.heading containing only an empty span.title . This causes issues with the layout.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/728, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cjctQH0K_A_3uD4A2NBBnbYxM1o0ks5skuJWgaJpZM4Pf_uR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LDNxe0FjsBMpGYBvvWax4Q9jYcx9ks5sku3DgaJpZM4Pf_uR.gif]

rbeezer commented 7 years ago

Done at e26e96e819ae3fb17706b1cad7dbb5550d4ee50e

Close if satisfied.

davidfarmer commented 7 years ago

Looks good.

Online HTML Sample Article needs to be updated.

rbeezer commented 7 years ago

On 09/22/2017 05:29 AM, David W. Farmer wrote:

Online HTML Sample Article needs to be updated.

Right! My upload script has been waiting all night for my password. ;-)