PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

Rename .hidden-knowl-wrapper #733

Closed davidfarmer closed 6 years ago

davidfarmer commented 7 years ago

How about ".kohere" as in "knowl open here".

If that class is on the "a" tag, then you don't need a surrounding div.hidden-knowl-wrapper, and the knowl will open after the "a". (So put that class on the a tag of a born-hidden example, but not on a footnote.)

That class can be used wherever we currently use .hidden-knowl-wrapper. Eventually I'll delete .hidden-knowl-wrapper from the knowls code.

Code is already in place. I'll modify the code if we choose a different class name than kohere.

rbeezer commented 7 years ago

That all sounds great. Thanks. A bit of admin this morning, then I'll get to this.

On 09/25/2017 04:34 AM, David W. Farmer wrote:

How about ".kohere" as in "knowl open here".

If that class is on the "a" tag, then you don't need a surrounding div.hidden-knowl-wrapper, and the knowl will open after the "a". (So put that class on the s tag of a born-hidden example, but not on a footnote.)

That class can be used wherever we currently use .hidden-knowl-wrapper. Eventually I'll delete .hidden-knowl-wrapper from the knowls code.

Code is already in place. I'll modify the code if we choose a different class name than kohere.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/733, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2ch6jyeKGxuRovH3yjfKTfWs6gMXdks5sl4_WgaJpZM4Pilz5.

rbeezer commented 7 years ago

Highly functional, and big code improvement (HTML, XSLT), but styling is not coming through.

http://mathbook.pugetsound.edu/beta/20170925-kohere/interesting-corollary.html

Correct me if some part of this is wrong (the id can move from a to article):

<article class="example-like">
  <a knowl="" class="id-ref kohere" refid="hk-example-structured" id="example-structured">
    <h5 class="heading">
      <span class="type">Example</span>
      <span class="codenumber">4.5</span>
      <span class="title">An Example of Structure</span>
    </h5>
  </a>
</article>
davidfarmer commented 7 years ago

I need to rework all of that, because the CSS was assuming the surrounding div.hidden-knowl-wrapper .

May take me a while.

On Mon, 25 Sep 2017, Rob Beezer wrote:

Highly functional, and big code improvement (HTML, XSLT), but styling is not coming through.

http://mathbook.pugetsound.edu/beta/20170925-kohere/interesting-corollary.html

Correct me if some part of this is wrong (the id can move from a to article):

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LKrUy0U-fFZ83uXfjr7zmqfJaSFbks5sl_E0gaJpZM4Pilz5.gif]

rbeezer commented 7 years ago

On 09/25/2017 12:10 PM, David W. Farmer wrote:

I need to rework all of that, because the CSS was assuming the surrounding div.hidden-knowl-wrapper .

May take me a while.

OK, thanks. I wasn't certain how much you had put in place. Let me know if you want more than that one page.

rbeezer commented 6 years ago

I'm not finding kohere nor hidden-knowl-wrapper in current output, and this is 9 months old, and I think we've moved on. So i am closing this, but it can be re-opened if necessary.