search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

Next button on Frontmatter page #739

Closed Alex-Jordan closed 7 years ago

Alex-Jordan commented 7 years ago

On the frontmatter page: http://mathbook.pugetsound.edu/examples/sample-article/html/

when there are no prefaces or other chunked subsections (as in the sample article), the "next" button is grayed out, but I think it could lead to the first thing that follows the frontmatter.

rbeezer commented 7 years ago

You mean like how "Reference" (the ) has a "Prev"?

I'm not sure where the difference is?

On 09/28/2017 07:29 PM, Alex Jordan wrote:

On the frontmatter page: http://mathbook.pugetsound.edu/examples/sample-article/html/

when there are no prefaces or other chunked subsections (as in the sample article), the "next" button is grayed out, but I think it could lead to the first thing that follows the frontmatter.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/739, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2ch80bXsfgSJTKkxnTzprrtiAoGauks5snFYfgaJpZM4PoH2S.

Alex-Jordan commented 7 years ago

I'm not sure where the difference is?

You don't see the symptom? Or you are unsure what the underlying code issue is?

I mean that if you follow that link, the "Next" button is grayed out and can't be clicked. I think it would be reasonable for it to be functional there.

I suspect it is looking for a subsection of the frontmatter, but in this case (and others) there is no subsection. It makes me wonder if a book chapter had no sections, but the chunk level was still 2, if this same issue would happen for that chapter.

rbeezer commented 7 years ago

Yes, I certainly can see what was reported.

And I believe it is inconsistent with the Prev button on "backmatter".

And I do not know why without more study of the (complicated) code.

On September 28, 2017 9:03:00 PM PDT, Alex Jordan notifications@github.com wrote:

I'm not sure where the difference is?

You don't see the symptom? Or you are unsure what the underlying code issue is?

I mean that if you follow that link, the "Next" button is grayed out and can't be clicked. I think it would be reasonable for it to be functional there.

I suspect it is looking for a subsection of the frontmatter, but in this case (and others) there is no subsection. It makes me wonder if a book chapter had no sections, but the chunk level was still 2, if this same issue would happen for that chapter.

rbeezer commented 7 years ago

Would you be willing to test that hypothesis?

I suspect it is looking for a subsection of the frontmatter, but in this case (and others) there is no subsection. It makes me wonder if a book chapter had no sections, but the chunk level was still 2, if this same issue would happen for that chapter.

Alex-Jordan commented 7 years ago

Tested, and the hypothesis is proven false. I don't see the issue in a sectionless chapter, only in a sectionless Frontmatter.

rbeezer commented 7 years ago

Thanks. I might peek at the code today if I get a chance.

On 09/29/2017 10:20 AM, Alex Jordan wrote:

Tested, and the hypothesis is proven false. I don't see the issue in a sectionless chapter, only in a sectionless Frontmatter.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbeezer/mathbook/issues/739#issuecomment-333186043, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy2cgHkZ0talRF2Ok16-fYk8iLFJihcks5snSbqgaJpZM4PoH2S.

rbeezer commented 7 years ago

Nice catch. Now I wonder why nobody noticed, never? Fixed at 5850453d477cd56a81c11e1ff6c0c66708773f4f

The frontmatter has a weird child, titlepage, that does not create a new page if chunking that far. And for an article, the only other child, abstract, does not either. But in a book, lots of children of frontmatter create their own page, like colophon.

You would have had no way to know, but the test would be to build a book/frontmatter with just a titlepage child (which I confirmed). See the commit for more details on the cause and cure.