PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
266 stars 208 forks source link

format error (either latex or html) with aside in example statement #746

Closed sepvar closed 1 year ago

sepvar commented 7 years ago

From discussion (point 3) https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!topic/pretext-support/c6feirQqC-c

I created a minimal example that shows the problem.

Summary: I would like an aside as the first item in the statement of an example. This screws up the LaTeX format. Modifications to fix it either cause a different format problem in LaTeX or in HTML. minimal-example.txt

Joe

sepvar commented 7 years ago

Follow-up. See discussion from Oct 2, 2017 in https://github.com/rbeezer/mathbook/issues/320

When I use the thmbox package, this issue is fixed for those environments that are redefined in the thmbox style. If I use the thmbox package but do not specify that specific environment then the issue above continues to be an issue for that environment. (So, for example, I can use the package to fix example without fixing heuristic.)

jjrsylvestre commented 1 year ago

I'm running into the same or a similar issue with aside inside example. example-aside.ptx.txt

rbeezer commented 1 year ago

I don't believe an aside is meant to go in an example. An aside is more like a block, a peer of an example.

On July 25, 2023 8:31:04 PM GMT+02:00, Jeremy Sylvestre @.***> wrote:

I'm running into the same or a similar issue with aside inside example. example-aside.ptx.txt

jjrsylvestre commented 1 year ago

Oh OK. I've tended to put aside in example when the content of the aside is relevant only to the example. I've also done

activity
  task
    p
    aside

and there isn't the same issue of the aside being pushed off to the side.

jjrsylvestre commented 1 year ago

Should the schema reflect this then? Right now

            ExampleLike =
                MetaDataTitleOptional,
                (
                    (BlockStatement)+ |
                    (Statement, Hint*, Answer*, Solution*) |
                    (IntroductionStatement?, Task+, ConclusionStatement?)
                )

and

            BlockStatement =
                BlockText |
                Figure | Aside |
                SideBySide | SideBySideGroup | Sage

Where else should aside not go?

rbeezer commented 1 year ago

Well, my memory was faulty, I guess. :-(

I'll investigate further next week.

On July 25, 2023 11:18:39 PM GMT+02:00, Jeremy Sylvestre @.***> wrote:

Should the schema reflect this then? Right now

           ExampleLike =
               MetaDataTitleOptional,
               (
                   (BlockStatement)+ |
                   (Statement, Hint*, Answer*, Solution*) |
                   (IntroductionStatement?, Task+, ConclusionStatement?)
               )

and

           BlockStatement =
               BlockText |
               Figure | Aside |
               SideBySide | SideBySideGroup | Sage

Where else should aside not go?

jjrsylvestre commented 1 year ago

I don't know if this is related to the aside issue in this thread, but has similar result:

Sometimes something like

example
    p
    figure
    p

causes the figure to be on the same line as the last line of the preceding p, so that the figure is pushed off toward the right margin instead of appearing between the paragraphs.

To fix it I have my post-processing routines insert a hard linebreak before the figure.

Don't know if this is related to https://groups.google.com/g/pretext-dev/c/eNBKkaD2Gbk/m/T_4X2wRmAAAJ in any way.

rbeezer commented 1 year ago

I had not forgotten this one! I think this is exactly what is going on in the recent thread you reference. And I just pushed a group of changes that includes "fixing" asides.

Do a pull, or wait from tomorrow's CLI nightly, and then can you test some situations with your hard-break fixes removed? Thanks.

jjrsylvestre commented 1 year ago

Ahead of you. I was following that -dev thread and decided to pull (1e7f7742) & rebuild this morning --- I was hoping to report in that thread that the changes fixed my issue with figures, but no luck. Then I remembered this similar issue and thought they might be related, so decided to comment here instead of hijacking that -dev thread.

Just rebuilt that example-with-aside test document that I attached to a previous comment in this thread, and the aside issue persists as well in 1e7f7742.

rbeezer commented 1 year ago

I misspoke. I'll need to fix examples to correct this. More later, gotta run right now.

On August 30, 2023 9:36:16 AM PDT, Jeremy Sylvestre @.***> wrote:

Ahead of you. I was following that -dev thread and decided to pull (1e7f7742) & rebuild this morning --- I was hoping to report in that thread that the changes fixed my issue with figures, but no luck. Then I remembered this similar issue and thought they might be related, so decided to comment here instead of hijacking that -dev thread.

Just rebuilt that example-with-aside test document that I attached to a previous comment in this thread, and the aside issue persists as well in 1e7f7742.

jjrsylvestre commented 1 year ago

Appears to be fixed by ed6467a5 (both the aside issue and the figure issue).