search

PreTeXtBook / pretext

PreTeXt: an authoring and publishing system for scholarly documents
https://pretextbook.org
Other
264 stars 206 forks source link

no number after text = title #992

Open kcrisman opened 5 years ago

kcrisman commented 5 years ago 
<p>One final twist.  If you say <c>text="title"</c>, then the title you assigned to the theorem will prefix the number.

Not true. You just get the title. Is that what we want? Is this a bug or a feature? I don't know. Sometimes I want "Wilson's Theorem 7.5.1", or maybe "Wilson's Theorem (7.5.1)" or maybe even "Theorem 7.5.1 (Wilson's Theorem)". And of course a lot of the time we would just want "Wilson's Theorem".

See also #172 which I honestly don't quite understand, but figure must be closely related.

It would be nice to have "title-global" and "title" like we have "global" and "type-global", maybe "title-text-global" permutations would be a bit excessive. But anyway in a "print" copy people will want to be able to cross-reference without looking in the index, so "Wilson's Theorem 7.5.1" could be useful, and I assume that <xref text="title" ref="myref" /> <xref text="global" ref="myref" /> would be intentionally bad code.

rbeezer commented 5 years ago

That entire section of documentation has not kept up with the code. :-(

Yes, title-global might be a good thing. title is there mostly for when you want an automatic clickable when a target does not have a number, so having a number was never part of the plan. But I can see where it would be useful.

rbeezer commented 4 years ago

Not true.

Retracted at f2afe50b0995e733c6ea2d6d0235044576b73724

Thanks for reporting this one.

rbeezer commented 4 years ago

Two things going on with this issue. Bug in documentation.

And a feature request. title-global and title-local could be good additions. But the style/look needs to be decided. And I want to wait a bit and not mix this in while I fix other nearby problems.

See 7541beb6bdb708c2895d9c28e21b63f0cd71992b and neighboring for guidance on where changes need to be made.

kcrisman commented 4 years ago

Glad this was helpful, no need for anything fast, as the only place I noticed was in the doc and would have done workarounds for anything I was doing personally.