search

PredatH0r / SteamServerBrowser

Browse game servers and details for games using Valve's master servers
126 stars 20 forks source link

disable auto-refresh when interval is '0' #7

Closed atomGit closed 9 years ago

atomGit commented 9 years ago

v1.12.2 title explains it i think - it appears that even when the auto-refresh interval is '0' that it still auto-refreshes

might also suggest renaming 'reload servers' to simply 'refresh'

PredatH0r commented 9 years ago

I checked the code... when you change the refresh interval, it stops the current timer and only if the value is > 0 it starts a new timer.

Reload/Refresh... I know it's confusing and I wish I had better names for it. The server browser in the Steam client calls has 2 separate buttons for "Quick Refresh" and "Refresh All". Maybe I should do it the same way.

"Reload servers" sends a new query with the server-side filters to the Valve master server and the browser receives a new list of servers. "Refresh" is not querying the master server, but only updates the status of the already known game servers.

atomGit commented 9 years ago

ok, if i understand you correctly there is apparently no way to refresh the list manually without reloading it (absent clicking on every item)

if that's the case, then yes, i'd think that there should be reload and refresh buttons - probably with descriptive tool-tips

also, is the master list being fetched at every start-up? - if so, i would vote to save the list on exit (and don't auto-refresh it on start-up if interval = 0

another tweak i think would be good is to cancel refreshing if the window loses focus or a game is being played (i would think the former may be easier since you don't have to poll for a 3rd party process) - perhaps there should be an option for this though?

oh, and off-topic, but where does it store its settings?

PredatH0r commented 9 years ago

"Quick Refresh" button was added in 1.13 to update current game server information without loading a new server list from the master server.