Predelnik / DSpellCheck

Notepad++ Spell-checking Plug-in
GNU General Public License v2.0
198 stars 33 forks source link

Mistakes v1.4.0 alpha3 #120

Closed DmFedorov closed 6 years ago

DmFedorov commented 6 years ago

in v1.4.0 alpha3 (I see that you are preparing a version of alpha4) 1) if Settings | Advanced = Split Words by the Following Delimiters: then..

2) checkbox in section Ignore Words "Having " does not seem to work (works if symbol is in list "Split Words by Non-Alphabetic Characters Except"). Maybe some others do not work too.

Predelnik commented 6 years ago

1st should be fixed in alpha4: https://github.com/Predelnik/DSpellCheck/releases/tag/v1.4.0-alpha4 As for 2nd it works as intended but I'm not sure if undescore should be part of exclusions by default.

SinghRajenM commented 6 years ago

As for 2nd it works as intended but I'm not sure if undescore should be part of exclusions by default.

No it is not working. Check/uncheck ("Having _" ) does not have any effect.

image

Predelnik commented 6 years ago

It should not have an effect if word does not contain _. In your case word is Aadhar it doesn't contain _ how it supposed to work in your opinion?

DmFedorov commented 6 years ago

It should not have an effect if word does not contain . In your case word is Aadhar it doesn't contain how it supposed to work in your opinion?

OK. Then this misunderstanding. Probably needed to translate the name of section "Ignore Words" as approximately "Words that ignored after splitting" or "(after splitting) Ignore Words:"


PS: list "Split Words by Non-Alphabetic Characters Except" probably should also have a tip: "Standard white-space symbols such as New Line ('\n'), Carriage Return ('\r'), Tab ('\t'), Space (' ') are always counted as delimiters" because this Non-Alphabetic symbols are always counted as delimiters and should be not excepted

SinghRajenM commented 6 years ago

In your case word is Aadhar it doesn't contain _ how it supposed to work in your opinion?

IMHO, word "Aadhar_Card" or "power" should be ignored if "Having " is checked similar to "Containing Numbers". And if the "Having _" is not checked, then treat them as separate words (e.g. Aadhar, Card, po, wer etc.).

image

Predelnik commented 6 years ago

IMHO, word "Aadhar_Card" or "power" should be ignored if "Having " is checked similar to "Containing Numbers". And if the "Having _" is not checked, then treat them as separate words (e.g. Aadhar, Card, po, wer etc.).

For me personally that sounds too complicated to make this option affect word splitting. The easier solution for me is just add it to the list of exclusions. Then it will "work" in default case just as it was "working" with default explicitly specified delimiters and "not working" when _ is selected as a delimiter.

In reality I don't think that option is even that useful or important anymore.

SinghRajenM commented 6 years ago

The easier solution for me is just add it to the list of exclusions.

As this option is default checked, I feel this is good to add it to the exclusion list. When use uncheck, this can be removed from exclusion list. However, most of the time users deal with default setting, so it should not be an issue.

image

I'm not much familiar with dspellcheck codebase, but I will try to debug and see if I can contribute towards this issue.

In reality I don't think that option is even that useful or important anymore.

If so, then I feel this option be removed from UI at all to avoid confusion. If user wants, he/she can add required delimiter(s) to exclusion list.

Predelnik commented 6 years ago

I'm not much familiar with dspellcheck codebase, but I will try to debug and see if I can contribute towards this issue.

This is not issue with codebase but with my vision how these things should be handled. Making checkbox affect delimiters in my opinion creates much more confusion. Also it removes the option to add/ignore words containing underscore manually. But my biggest gripe with all of it is that nothing has changed except the set of default delimiters which now happen to contain underscore.

Predelnik commented 6 years ago

I added underscore to default exclusions in master. Hopefully it resolves this issue.