Predelnik / DSpellCheck

Notepad++ Spell-checking Plug-in
GNU General Public License v2.0
198 stars 33 forks source link

v1.4.0 - does not spell check text in HTML files #128

Closed ballios closed 6 years ago

ballios commented 6 years ago

v1.4.0 (stable) does NOT spell check at all - Russian, English. I use Hunspell library (as always, many years) but only in v1.4.0 I have such big problem of spell check totally inactive. Sergey, please fix this issue as fast as you can. I am completely discouraged...

Predelnik commented 6 years ago

Can you describe your problem in more detail please, for example starting with which system you use, what kind of Notepad++ installation do you have, etc. Because quite obviously it works for me.

ballios commented 6 years ago

I have:

I already wrote to you that v1.3.5 - is working normally. After I updated via Plugin Manager (as always) on v1.4.0 - this DSpellCheck problem appeared.

Predelnik commented 6 years ago

How does the problem manifest itself? Nothing is underlined? Does find next/ find prev. misspelling menu items work? Is there any dictionaries in Plugins->Change Current Language Can you also show me the contents of the file %appdata%/Notepad++/plugins/config/DSpellCheck.ini? If Hunspell doesn't work can you check if native speller does work (since it should be usable on windows 10)? image

ballios commented 6 years ago

I understood the problem.

v1.4.0 - does NOT check at all (neither Russian, nor English) in all files with the extension .html But it checks correctly (Russian, English) only in files with the extension .txt

There is no such problem in v1.3.5.

In Notepad - I have (as always) files and .html and .txt

Please fix this for v1.4.0

P.S. Win 10 spell check is not acceptable due to its extreme slow down in Notepad!

Predelnik commented 6 years ago

Thanks! I changed the code determining which parts of text should be checked for various languages in this release and messed up this part for HTML a bit. I will probably make a proper release with fix this weekend. (also will double check this for some other mostly-text languages like tex)

Here's version where I hopefully fixed this for html: https://drive.google.com/uc?export=download&id=1eGya-P3lcjGrPfWFeDC8lOlx3suKJPIi It would be great if you make sure that it works for you.

P.S. Win 10 spell check is not acceptable due to its extreme slow down in Notepad!

Yeah it's the slowest one currently due to being non-native, but dictionaries are not that bad. And there is possibly some ways to speed-up still left. But anyway I was recommending it not as a permanent switch but only as a check that this is not a problem only with Hunspell but now I see that it's not.

ballios commented 6 years ago

Thanks a lot! I will wait for the official release with impatience!

Predelnik commented 6 years ago

I've created 1.4.1 with this fix https://github.com/Predelnik/DSpellCheck/releases/tag/v1.4.1 It will be updated on plugin manager in a while.

ballios commented 6 years ago

I don't know why v1.4.1 is not visible in plugin manager? Still v1.4.0 only....

Predelnik commented 6 years ago

Yes it takes a while for it to update, it may take a week or so.

Predelnik commented 6 years ago

1.4.1 now is available on 32 and 64-bit plugin managers, so I'm closing this for now. Feel free to reopen if you still have issues.