search

Predelnik / DSpellCheck

Notepad++ Spell-checking Plug-in
GNU General Public License v2.0
198 stars 33 forks source link

DSpellCheck makes Notepad++ crash #146

Closed donho closed 5 years ago

donho commented 6 years ago

FYI @Predelnik : https://github.com/notepad-plus-plus/notepad-plus-plus/issues/4752#issuecomment-414968250 and https://github.com/notepad-plus-plus/notepad-plus-plus/issues/4083#issuecomment-414913104

donho commented 6 years ago

@Predelnik It seems the crash has been fixed in v1.4.6 : https://github.com/notepad-plus-plus/notepad-plus-plus/issues/4752#issuecomment-414968250

Is this version stable enough for being included in the new Notepad++ release?

Predelnik commented 6 years ago

Hi, Don Ho. 1.4.6 should not contain any serious problems hopefully since at least some people use it through plugin manager. However browsing through changelog I don't remember fixing this kind of crash intentionally, so maybe it would be nice to still get a crash dump to make sure that it is properly fixed.

Looking at #4083 it seems I also should not add alt + ... hotekys by default since it breaks hotkeys for some languages. I will probably change that in next version.

Best regards, Sergey Semushin

On Thu, Aug 23, 2018 at 7:36 PM Don HO notifications@github.com wrote:

@Predelnik https://github.com/Predelnik It seems the crash has been fixed in v1.4.6 : notepad-plus-plus/notepad-plus-plus#4752 (comment) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/4752#issuecomment-414968250

Is this version stable enough for being included in the new Notepad++ release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Predelnik/DSpellCheck/issues/146#issuecomment-415370358, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCPxSWVvSY4gIfgylgW_GEItArtED7Yks5uToWbgaJpZM4WHqMA .

donho commented 5 years ago

@Predelnik FYI. In case that you are not aware of it, DSpellCheck v1.4.6 has been included in the latest version of Notepad++ (v7.5.9).

Predelnik commented 5 years ago

Thank you for the heads up! Hopefully it solves the issue.

vaxul commented 5 years ago

@donho

In case that you are not aware of it, DSpellCheck v1.4.6 has been included in the latest version of Notepad++ (v7.5.9).

What does this mean? I haven't found any of this in changelogs. Is it not necessary to install DSpellCheck separate as plugin?

I have v7.5.9 and after an update or clean install of DSpellCheck v1.4.7 Notepad++ crashes at every start till I remove the plugin (within the plugin folder).

donho commented 5 years ago

@vaxul Could you provide the detail of your config here by using Menu "?->Debug Info"? @Predelnik Have you noticed any crash since 1.4.7 ?

vaxul commented 5 years ago

@donho 

Notepad++ v7.5.9   (32-bit)
Build time : Oct 14 2018 - 15:02:52
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 10 (64-bit)
Plugins : mimeTools.dll NppExport.dll ComparePlugin.dll HTMLTag_unicode.dll NppEditorConfig.dll NppTextFX.dll NppToolBucket.dll PluginManager.dll

If I try to reinstall the latest Version of DSpellCheck (1.4.7) from the Plugin Manager, Notepad++ crashes with every start without an error message.

I found no logs, to dig into the crash issue.

Predelnik commented 5 years ago

@vaxul

If it's possible can you please create dump file of Notepad++ after crash happens and send it to me (most likely through Google Drive / Dropbox link since it may not fit to e-mail attachment). Here is how it should be possible in Task Manager: image

The other thing which may be useful is contents of your plugin settings file located in %appdata%\Notepad++\plugins\config\DSpellCheck.ini.

@donho No crash on start was specifically fixed in 1.4.7 and hopefully nothing crash inducing was added either. But I would definetily would like to fix it asap in next version.

Branwyn commented 5 years ago

confirm it start crashing after installing NPP++ v. 7.6. (plugin version 1.4.7)

in my case - understood crash was caused by setting (from previous installation) plugin to check multiple languages (Aspell, any language more then one selected, same time - spell checking of each language is working fine if set separately).

found this initially by switching off each plugin to find the reason of crash on startup, then by replacing content of my INI from previous version installed:

[SpellCheck]
Aspell_Multiple_Languages=en|en_US|ru|uk
Aspell_Language=<MULTIPLE>
Hunspell_Language=en_US
Library=0

with freshly installed INI:

[SpellCheck]
Autocheck=0
Hunspell_Language=en_US

and then by experimenting with number of languages to be checked.

vaxul commented 5 years ago

After removing the existing %appdata%\Notepad++\plugins\config\DSpellCheck.ini. Notepad++ doesn't crashing after installing DSpellCheck.

The content of the INI before:

[SpellCheck]
Aspell_Multiple_Languages=de|de_DE|en|en_GB|en_GB-w-accents
Aspell_Language=<MULTIPLE>
Library=0

After redefine the config the INIs content is:

[SpellCheck]
Hunspell_Multiple_Languages=en_GB|en_US|de_DE_frami
Hunspell_Language=<MULTIPLE>

So Hunspell is working.

Switching the INI back to the faulty one lets NPP+ crashing again.

EDIT: Switching settings manually to Aspell let's NPP+ after restart. Which results in config:

[SpellCheck]
Aspell_Multiple_Languages=de_DE|en_GB|en_US
Aspell_Language=<MULTIPLE>
Hunspell_Multiple_Languages=en_GB|en_US|de_DE_frami
Hunspell_Language=<MULTIPLE>
Library=0

I had Aspell installed some time before I switched to this plugin. Version used:

And for completion, setting Library to "native" does also work:

[SpellCheck]
Native_Speller_Multiple_Languages=en-US|de-DE
Native_Speller_Language=<MULTIPLE>
Library=2

If it's possible can you please create dump file of Notepad++ after crash happens

The process is killed while NPP+ is crashing.

Predelnik commented 5 years ago

Ok so it seems this crash is truly caused by version 1.4.7 changes. I even noticed the possibility of it but deemed it to be not serious. Can you please check that the version below no longer crashes with your original settings file? https://ci.appveyor.com/api/buildjobs/2u9whys9s0vaagwm/artifacts/DSpellCheck.dll

If it does not I will try to release a version with the fix as soon as possible.

Note that this crash has nothing to do with issues linked in the topic and affects only version 1.4.7.

Branwyn commented 5 years ago

no crashes with DLL as per provided above link (albeit difference in size of approx 1 mb)

vaxul commented 5 years ago

I testet the x86 Version https://github.com/Predelnik/DSpellCheck/releases/tag/v1.4.6 with the old config it NPP++ doesn't crash with it.

https://ci.appveyor.com/api/buildjobs/2u9whys9s0vaagwm/artifacts/DSpellCheck.dll

This one does also work.

Predelnik commented 5 years ago

Ok, thank you very much for testing! I will try to officially release new version with the fix today or tomorrow.

albeit difference in size of approx 1 mb

Oh don't worry too much about it, official release will probably have the same size. It's just some difference in appveyor build script (appveyor is an utility for quickly checking that plugin builds) from normal build I do. It would be interesting to find out what's different but it isn't critical in any way.

Predelnik commented 5 years ago

1.4.8 is now available through plugin manager, so second (aspell users only) crash discussed in this issue is fixed, closing.

donho commented 5 years ago

@Predelnik Thank you for fixing it. Please do a PR here to update DSpellCheck status in Plugins Admin: https://github.com/notepad-plus-plus/nppPluginList

Predelnik commented 5 years ago

@donho Sure! I will look into that, probably need a bit of time to figure out how to test things locally.