Predelnik / DSpellCheck

Notepad++ Spell-checking Plug-in
GNU General Public License v2.0
198 stars 33 forks source link

crash when use the develop npp++ from 29.01.2020 #280

Closed KlausiD closed 2 years ago

KlausiD commented 2 years ago

the plugin is crash when use the develop npp++! npp++ has change the interface see: https://github.com/notepad-plus-plus/notepad-plus-plus/issues/11104#issuecomment-1024934304 and https://github.com/notepad-plus-plus/notepad-plus-plus/pull/11047#issuecomment-1024048200

pryrt commented 2 years ago

FYI: per this and this, with v8.2.2 RC5, the NPP installer is actively disabling DSpellCheck for anyone who has it already installed, and that might mean he's also removed it from Plugins Admin (though I'm not sure) -- which means that users are going to have to start fighting against Don unless an update-with-patch is released ASAP (preferably before v8.2.2 is fully released)

donho commented 2 years ago

@Predelnik Here's the complement info:

Due to the support 2GB files opening in Notepad++ v8.2.2 x64 build, the header Sci_Position.h in Notepad++ has been modified for adapting this need. This change has caused the instability of DSpellCheck.

How to reproduce crash:

  1. Install DSpellCheck Plugin in Notepad++ v8.2.2 x64 build
  2. Restart Notepad++ -> Notepad++ crash

The solution is quite simple - just replace Sci_Position.h by the new one (or just replace typedef long Sci_PositionCR; by typedef intptr_t Sci_PositionCR; in Sci_Position.h of your project), then recompile DSpellCheck. ref: https://community.notepad-plus-plus.org/topic/22471/recompile-your-x64-plugins-with-new-header

Could you please update DSpellCheck ASAP (and also PluginList) so I could work on installation (NSIS) script to remove only the old versions, but keep the new fixed version, just as how installer deals with NppSaveAsAdmin plugin currently.

Sorry for the inconvenience and thank you in advance for your help.

ArkadiuszMichalski commented 2 years ago

@Predelnik When can we expect a new release? Edit: I see when: https://github.com/Predelnik/DSpellCheck/pull/281#issuecomment-1028779799

donho commented 2 years ago

@Predelnik Please do a PR on Plugin list for your new release. I can include it (modify NSIS and include the newest PluginList) if your release and PR on Plugin list is on time (ie. in about 4 hours). Otherwise no problem - Notepad++ will be released more frequently with updated plugin list to ensure its usability.

Thank you for your help!

Predelnik commented 2 years ago

Don't know if I was in time or not, but here it is: https://github.com/Predelnik/DSpellCheck/releases/tag/v1.4.23

https://github.com/notepad-plus-plus/nppPluginList/pull/405

Unfortunately I'm sick right now, so my response time is a bit delayed, sorry.

Yaron10 commented 2 years ago

@Predelnik,

👍 Thank you for your work.

I hope you get better soon.

donho commented 2 years ago

It's right on time! I'm doing the release. Thank you @Predelnik for your help, and hope you getting better soon.