search

PredictionIO / template-scala-parallel-universal-recommendation

PredictiionIO Template for Universal Recommender
111 stars 48 forks source link

allowing for configuration of entityType and targetEntityType through JSON #29

Closed ghost closed 8 years ago

ghost commented 8 years ago

Rather than defaulting to user and item in code, I've moved the entityType and targetEntityType configurations to the engine's JSON file and provided parameter defaults. I've also cleaned up the README's spacing and fixed two minor esClient issues (an unneeded import and using "items" instead of the indexType param).

ghost commented 8 years ago

I guess there really isn't a good use case for this. Closing.

pferrel commented 8 years ago

I think of events going into the EventServer as always a tuple (user-id, event-name, item-id) where the item type is inferred by the event-name. This is the most minimal way to represent these.

This makes the targetEntityType superfluous, and therefore ignored. It is only used because it is needed by the framework, not because it holds any meaning so I agree, no real need.