cboisvenue
commented
3 years ago All checked. The three functions are correct
Closed cboisvenue closed 3 years ago
cboisvenue
commented
3 years ago All checked. The three functions are correct
The function spatialUnitDecayRates() used in CBM-defaults.R is the last function of three used in CBMutils to calculate the decay rates for each spatial unit from the decay parameters in provided in CBM-CFS3 (sim$cbmData@decayParameters). This input data (sim$cbmData@decayParameters) provides a OrganicMatterDecayRate a ReferenceTemp a Q10 value a PropToAtmosphere and a MaxDecayRate which is set to 1. There was a mismatch between the description provided in an excel spreadsheet of the decay function and that in the three embedded fncts to calculate decay rates per spatial unit. In the matrices described in an excel spreadsheet given to me by Scott Morken, one of the parentheses is in the wrong place. The 2009 publication was checked and the parenthesis matches the formula in the CBMutils function and it is correct. The three embedded functions are: spatialUnitDecayRates( getDecayRates( decayRate(the formula is in here))).
Another important note is that the maximum decay rate (set to 1 for all DOM pools) was also checked. As specified in the 2009 publication, in CBM-CFS2, there was a stand modifier for decomposition under open canopy. In the CBM-CFS3 the value defaults to one because more recent studies that examined open canopy effects on decomposition indicated that decomposition rates are not always higher under open canopies (as represented in CBM-CFS2) and that decomposition rate responses may be ecosystem specific (Yanai et al., 2000).