search

PredictiveEcology / SpaDES

R package for developing and running Spatial Discrete Event Simulation models
https://spades.predictiveecology.org
Other
55 stars 21 forks source link

downloadModule/downloadData should check for local files before checking remotely for download #319

Closed achubaty closed 6 years ago

achubaty commented 8 years ago

Although the files exist locally, downloadModule is still checking for the existence of the module remotely for download.

This is a bigger problem with GitHub's API rate limits because only a few calls to downloadModule are needed to trigger a 403 error. The checkModule() call early in the downloadModule() function is being called without first checking to see whether files exist locally. It's worth implementing a local check/checksum for module code, in addition to the checks for downloading data.

eliotmcintire commented 8 years ago

@melinahoule This may be relevant to our discussions today

achubaty commented 8 years ago

note that my changes made in 3e56cf9 aren't checksumming or doing anything special when checking for local copies of modules -- just looking for a presence of a few files and checking the version. this should be made more robust.

achubaty commented 6 years ago

This issue was moved to PredictiveEcology/SpaDES.core#17