PredictiveEcology / SpaDES

R package for developing and running Spatial Discrete Event Simulation models
https://spades.predictiveecology.org
Other
55 stars 21 forks source link

spread and timeunits tests failing #335

Closed achubaty closed 7 years ago

achubaty commented 7 years ago

errors also likely on winbuilder too, but I have not tested.

7. Error: spreadProb with relative values does not work correctly (@test-spread.R#1198) 
8. Error: timeunits with child and parent modules work correctly (@test-timeunits.R#150)

e.g., see here

achubaty commented 7 years ago

@eliotmcintire these are failing for me locally as well

achubaty commented 7 years ago

@eliotmcintire I'm getting these failures locally too.

spread example is also failing:

...
> #seed <- 576534
> set.seed(seed); print(seed)
[1] 957139
> maxSizes <- rexp(length(startCells), rate = 1 / 500)
> fires <- spread(hab, loci = startCells, 1, persistence = 0,
+                 neighProbs = c(0.5, 0.5, 0.5) / 1.5,
+                 mask = NULL, maxSize = maxSizes, directions = 8,
+                 iterations = 1e6, id = TRUE, plot.it = FALSE, exactSizes = TRUE);
Warning in tmpA < numNeighs :
  longer object length is not a multiple of shorter object length
Error in spread(hab, loci = startCells, 1, persistence = 0, neighProbs = c(0.5,  : 
  NAs are not allowed in subscripted assignments
Calls: spread -> spread
Execution halted

I've temporarily skipped the failing timeunits test (7b3a6002d7ea2605c823c72647a0b87b922e6612), which seems to recurse incorrectly during simInit.

achubaty commented 7 years ago

@eliotmcintire failing on travis too. perhaps a recent change to a package has triggered this.