search

PredictiveEcology / SpaDES

R package for developing and running Spatial Discrete Event Simulation models
https://spades.predictiveecology.org
Other
55 stars 21 forks source link

Development #343

Closed MelinaHoule closed 7 years ago

MelinaHoule commented 7 years ago

Implement Cache with side effect functionalities

eliotmcintire commented 7 years ago

Melina,

There are several tests that fail when I test your pull request. Do know how to read these? Failure 1: on line 73 of the test-cache.R file etc.

testthat results

OK: 950 SKIPPED: 15 FAILED: 5

  1. Error: test event-level cache (@test-cache.R#73)
  2. Error: test module-level cache (@test-cache.R#136)
  3. Error: test file-backed raster caching (@test-cache.R#189)
  4. Error: test-dwdData (@test-dwdData.R#22)

Eliot

On Fri, May 12, 2017 at 11:47 AM, MelinaHoule notifications@github.com wrote:

Implement Cache with side effect functionalities

You can view, comment on, or merge this pull request online at:

https://github.com/PredictiveEcology/SpaDES/pull/343 Commit Summary

  • Add sideEffect, makeCopy to cache
  • Fix params definition
  • Add temp scritp "cache_test.R" to run cache , add cache_test to collate
  • implement MakeCopy and SideEffect
  • Fix dwdData and argument in CACHE (sideEffect, makeCopy). Implement test-dwDData
  • Merge branch 'development' into MelinaDevelopment
  • ignore sqLite file
  • Fix Cache ligne 195, 205. Delete dwdData from SpaDES
  • implement Cache FUN with side effect

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PredictiveEcology/SpaDES/pull/343, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDK279lOK3C9ygHLkncma1Zo39KwNu_ks5r5KlYgaJpZM4NZpp3 .

achubaty commented 7 years ago

Since caching has been moved into another package (https://github.com/PredictiveEcology/reproducible), I'm closing this PR.

@MelinaHoule once you fix the errors etc., please submit the PR against the other package. THank you.