search

PredictiveEcology / WesternBorealInitiative

https://wbi.predictiveecology.org
3 stars 3 forks source link

Update site files #16

Closed psolymos closed 11 months ago

psolymos commented 11 months ago

This PR contains the files currently deployed at https://wbi.predictiveecology.org with the apps listed.

eliotmcintire commented 11 months ago

@psolymos This doesn't seem to contain the source e.g., Rmds for those pages, so they will be overwritten if we build the site locally and push. Since we will have changes to other parts of the site, is it possible to get those also?

psolymos commented 11 months ago

I was editing the rendered output. But we can look into that. That would also work well with the webhook that we have set up (we can pull the contents after a successful build step).

Would it be OK if the theme is different but the content is the same? Using a different template might be easier, I recall I was having some difficulties with the top navigation bar and that is why I chose to edit the HTML directly.

eliotmcintire commented 11 months ago

Theme change is fine. Currently, the top menu is created by the _site.yml file in the website folder. It relies on having an Rmd for each page... so there would have to be an apps.Rmd file inside website folder, and then add apps.html to the _site.yml file as per the other ones already there.

eliotmcintire commented 11 months ago

I just made the app.Rmd file and added it to the _site.yml and it looks like it all works. I will make a PR so everyone can see it.

On Thu, Oct 5, 2023 at 11:09 AM Peter Solymos @.***> wrote:

I was editing the rendered output. But we can look into that. That would also work well with the webhook that we have set up (we can pull the contents after a successful build step).

Would it be OK if the theme is different but the content is the same? Using a different template might be easier, I recall I was having some difficulties with the top navigation bar and that is why I chose to edit the HTML directly.

— Reply to this email directly, view it on GitHub https://github.com/PredictiveEcology/WesternBorealInitiative/pull/16#issuecomment-1749409457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIMVW7W4IMYSFBVXIZUMQDX53ZVJAVCNFSM6AAAAAA5TZ3N62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGQYDSNBVG4 . You are receiving this because you modified the open/close state.Message ID: @.*** com>

eliotmcintire commented 11 months ago

https://htmlpreview.github.io/?https://raw.githubusercontent.com/PredictiveEcology/WesternBorealInitiative/appsMenu/docs/index.html

It is not getting the favicon.ico for some reason... the file is there. Maybe it is because it is using the htmlpreview service that the favicon doesn't show up in the browser tab

On Thu, Oct 5, 2023 at 11:36 AM Eliot McIntire @.***> wrote:

I just made the app.Rmd file and added it to the _site.yml and it looks like it all works. I will make a PR so everyone can see it.

On Thu, Oct 5, 2023 at 11:09 AM Peter Solymos @.***> wrote:

I was editing the rendered output. But we can look into that. That would also work well with the webhook that we have set up (we can pull the contents after a successful build step).

Would it be OK if the theme is different but the content is the same? Using a different template might be easier, I recall I was having some difficulties with the top navigation bar and that is why I chose to edit the HTML directly.

— Reply to this email directly, view it on GitHub https://github.com/PredictiveEcology/WesternBorealInitiative/pull/16#issuecomment-1749409457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIMVW7W4IMYSFBVXIZUMQDX53ZVJAVCNFSM6AAAAAA5TZ3N62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGQYDSNBVG4 . You are receiving this because you modified the open/close state.Message ID: @.*** .com>

psolymos commented 11 months ago

Favicon is usually a browser caching problem. It should work once deployed if the file is served correctly.

eliotmcintire commented 11 months ago

So, I will accept the PR and it seems to be fine. If something breaks, then we can revert.

But it means that we now build the site with the Rstudio button (Build website on the "Build" tab) -- which is MUCH faster than the command: system.time(rmarkdown::render_site(input = "website", encoding = 'UTF-8'))

On Thu, Oct 5, 2023 at 12:50 PM Peter Solymos @.***> wrote:

Favicon is usually a browser caching problem. It should work once deployed if the file is served correctly.

— Reply to this email directly, view it on GitHub https://github.com/PredictiveEcology/WesternBorealInitiative/pull/16#issuecomment-1749549109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIMVW47Z7WWWYVNVRLFME3X54FRTAVCNFSM6AAAAAA5TZ3N62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGU2DSMJQHE . You are receiving this because you modified the open/close state.Message ID: @.*** com>

psolymos commented 11 months ago

@eliotmcintire Is the the following?

  1. Make changes to rmd (website) folder locally
  2. Build the site (RStudio button or render_site())
  3. Git push the changes to master

The benefit is that you can check the output locally and push when you like it.

I am asking because of the webhook that should deploy the static content deployment to the server. It would clone the repo and copy the docs folder to its destination.

Can you give me write access to this repo so that I can set up the webhook secret? Thanks.

eliotmcintire commented 11 months ago

"yes" that is right. The web hook is fine also. There is a tradition in the Rmarkdown world because of how R packages had vignettes in a folder called "vignettes", that the user didn't change things in a docs folder... rather the various tools in the toolchain (pkgdown, rmarkdown) would build the site and push everything to the docs folder, which essential was a "read only" folder.

On Thu, Oct 5, 2023 at 3:52 PM Peter Solymos @.***> wrote:

@eliotmcintire https://github.com/eliotmcintire Is the the following?

  1. Make changes to rmd (website) folder locally
  2. Build the site (RStudio button or render_site())
  3. Git push the changes to master

The benefit is that you can check the output locally and push when you like it.

I am asking because of the webhook that should deploy the static content deployment to the server. It would clone the repo and copy the docs folder to its destination.

Can you give me write access to this repo so that I can set up the webhook secret? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/PredictiveEcology/WesternBorealInitiative/pull/16#issuecomment-1749763698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIMVW5O5HLIT4OLXH72PBLX5424BAVCNFSM6AAAAAA5TZ3N62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZG43DGNRZHA . You are receiving this because you were mentioned.Message ID: @.***>

eliotmcintire commented 11 months ago

Can you give me write access to this repo so that I can set up the webhook secret? Thanks.

Done

psolymos commented 11 months ago

Can you give me write access to this repo so that I can set up the webhook secret? Thanks.

Done

Looks like I need to be an admin to see the Settings.

psolymos commented 11 months ago

"yes" that is right. The web hook is fine also. There is a tradition in the Rmarkdown world because of how R packages had vignettes in a folder called "vignettes", that the user didn't change things in a docs folder... rather the various tools in the toolchain (pkgdown, rmarkdown) would build the site and push everything to the docs folder, which essential was a "read only" folder.

That is fair. However, I don't quite like having zillion files in the docs folder as it happens with HTML rendering (vignettes are Rmd or LaTeX without the locally served js/css assets). So I usually push pages to the gh-pages branch when hosting with gh pages. This site is a bit different though, contents are served from the Alliance VM.