search

PrefLib / preflibtools

A small and lightweight Python package for working with and generating data from www.PrefLib.org.
https://preflib.github.io/preflibtools/
GNU General Public License v3.0
11 stars 8 forks source link

Refactoring #10

Closed claussmann closed 11 months ago

claussmann commented 11 months ago

I refactored the structure a little bit. Mainly, I split the properties.basic file in to two files, and moved the decorators to the properties.decorators because it feels more natural to put them there instead of the aggregation sub-package.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ce8f01f) 85.08% compared to head (9bd7052) 65.97%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## =========================================== - Coverage 85.08% 65.97% -19.11% =========================================== Files 12 13 +1 Lines 1240 1246 +6 =========================================== - Hits 1055 822 -233 - Misses 185 424 +239 ``` | [Files](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib) | Coverage Δ | | |---|---|---| | [preflibtools/aggregation/singlewinner.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL2FnZ3JlZ2F0aW9uL3NpbmdsZXdpbm5lci5weQ==) | `98.03% <100.00%> (+70.58%)` | :arrow_up: | | [preflibtools/instances/sampling.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL2luc3RhbmNlcy9zYW1wbGluZy5weQ==) | `97.00% <100.00%> (+0.03%)` | :arrow_up: | | [preflibtools/properties/\_\_init\_\_.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL3Byb3BlcnRpZXMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [preflibtools/properties/basic.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL3Byb3BlcnRpZXMvYmFzaWMucHk=) | `59.37% <ø> (-23.52%)` | :arrow_down: | | [preflibtools/properties/decorators.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL3Byb3BlcnRpZXMvZGVjb3JhdG9ycy5weQ==) | `85.71% <100.00%> (ø)` | | | [preflibtools/properties/metrics.py](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib#diff-cHJlZmxpYnRvb2xzL3Byb3BlcnRpZXMvbWV0cmljcy5weQ==) | `68.18% <68.18%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/PrefLib/preflibtools/pull/10/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PrefLib)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Simon-Rey commented 11 months ago

It's merged but some stuff have changes, see the latest commits