PrefectHQ / graphs

Large scale graphs designed for Prefect
Apache License 2.0
9 stars 1 forks source link

Bugfix: update flowRunArtifact positions on child render #413

Closed brandonreid closed 8 months ago

brandonreid commented 8 months ago

Since turning flowRunArtifact into essentially a thin wrapper for artifact and artifactCluster that handles position, I discovered that positions weren't being called when the child render functions were fired, resulting in false positioning.

https://github.com/PrefectHQ/graphs/assets/6776415/0cecc14a-1d4c-4874-9cf7-e11b2bce6084

Now the updatePosition function is always called after the child render functions are.

https://github.com/PrefectHQ/graphs/assets/6776415/67ae0dd1-1a7a-46d8-9bbe-ff64acf1d171

netlify[bot] commented 8 months ago

Deploy Preview for prefect-graphs ready!

Name Link
Latest commit 25845d6f054e1e2b1b1ba9783d98cb2b31fa9b5b
Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65cfa78b03686f00089d8c11
Deploy Preview https://deploy-preview-413--prefect-graphs.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.