search

PrefectHQ / graphs

Large scale graphs designed for Prefect
Apache License 2.0
9 stars 1 forks source link

Bugfix: artifact cluster measurements on emit #446

Closed brandonreid closed 5 months ago

brandonreid commented 5 months ago

For root level artifacts, the viewport scale was being included in selection dimensions, which caused inaccurate overlay boxes from the popover.

netlify[bot] commented 5 months ago

Deploy Preview for prefect-graphs ready!

Name Link
Latest commit c37cef9e772129974ecf97698973c25fd2b3dab4
Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65ef4035e83fb70008027925
Deploy Preview https://deploy-preview-446--prefect-graphs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pleek91 commented 5 months ago

@brandonreid can you explain why? In my mind it shouldn't matter if the element is a cluster or not the logic should be the same 🤔

znicholasbrown commented 5 months ago

Approved to make sure you're not blocked but the comment above should be addressed

brandonreid commented 5 months ago

@pleek91 @znicholasbrown

Wow, good looking out fellas. I think I meant to check if it was from a root node or not, but I actually don't need to scale the selection div at all. 😅

Updated. I'll assume you'd approve the now very simple change.