PrefectHQ / graphs

Large scale graphs designed for Prefect
Apache License 2.0
9 stars 1 forks source link

Fix: Prefent node dimming if selecting from differing scope #450

Closed brandonreid closed 5 months ago

brandonreid commented 5 months ago

Currently, when selecting a subflow, the parent node is dimmed, causing all subflow nodes to also dim regardless of whether or not they contain a selection.

image

This PR makes it so that nodes aren't dimmed if the selected node doesn't exist in the current scope of nodes. Ideally, we'd find the subflow node containing the selection and highlight the path. This get's tricky with recursion, like if you select a subflow node that's 5 subflows deep. So this is a fast and improved solution, but not quite ideal. If I have time I'll pursue the ideal solution in a way that doesn't necessitate too much recursion.

After:

image
netlify[bot] commented 5 months ago

Deploy Preview for prefect-graphs ready!

Name Link
Latest commit 8fef885e760778f9a6492fe7b45f57929b0f3755
Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65ef326fef843e0008ef2b5a
Deploy Preview https://deploy-preview-450--prefect-graphs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.