search

PrefectHQ / graphs

Large scale graphs designed for Prefect
Apache License 2.0
9 stars 1 forks source link

Bugfix: hide artifacts when setting changes #456

Closed brandonreid closed 5 months ago

netlify[bot] commented 5 months ago

Deploy Preview for prefect-graphs ready!

Name Link
Latest commit c1ff30e066a0db0bf1f0a46a8b2b99310e7ad420
Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65f314b783917c0008bc7e76
Deploy Preview https://deploy-preview-456--prefect-graphs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pleek91 commented 5 months ago

@brandonreid For things like edges we actually remove them rather than just hiding them. Is there a specific reason you're hiding them for this?

brandonreid commented 5 months ago

@pleek91 Updated to remove artifacts and events when either are hidden.

Originally, given that these are rendered in multiple places (root run, on subflows, on nodes) it felt like less places to maintain hiding things to use visibility on the element's factory rather than each parent checking and removing. After trying it though, it actually cleans up some things for the parents and seems better, nice to not have hidden things on the stage as well.