PrefectHQ / graphs

Large scale graphs designed for Prefect
Apache License 2.0
9 stars 1 forks source link

Fix: Gradient fills on nodes if zoomed screen #460

Closed brandonreid closed 5 months ago

brandonreid commented 5 months ago

Resolves https://github.com/PrefectHQ/graphs/issues/459

Nodes were appearing to have gradient fills when the browser was zoomed:

image

After digging into the PIXI discord for a while, it seems that this happens when floats are provided for the resolution (e.g. 2.5 or 1.7777). Rounding this resolution up to a whole number solves the issue and errs on the side of higher resolution rather than lower, so things still render nice and sharp.

image
netlify[bot] commented 5 months ago

Deploy Preview for prefect-graphs ready!

Name Link
Latest commit 57c826154b28ab7fe1e57d42143c57144432c428
Latest deploy log https://app.netlify.com/sites/prefect-graphs/deploys/65f4368bf1f5540008f07bcb
Deploy Preview https://deploy-preview-460--prefect-graphs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.