PrefectHQ / marvin

✨ Build AI interfaces that spark joy
https://askmarvin.ai
Apache License 2.0
5.34k stars 348 forks source link

Audio#record should return Audio Type ? #918

Closed hirokidaichi closed 7 months ago

hirokidaichi commented 7 months ago

https://github.com/PrefectHQ/marvin/blob/f4ec4eef128d6264849e5fa6e4f99134258fafbb/src/marvin/audio.py#L121

I apologize if my understanding of the code was incorrect. In the part where the Audio object is supposed to be returned, there seem to be two return statements, exposing different data types.

zzstoatzz commented 7 months ago

thanks for the issue @hirokidaichi - yes this was a mistake. we should be returning the right audio type here now