search

PrefectHQ / prefect-collection-template

Template to quickly bootstrap a Prefect Collection
Apache License 2.0
66 stars 9 forks source link

Remove python3.8 nightly test #156

Closed giorgiobasile closed 1 month ago

giorgiobasile commented 4 months ago

Removes python 3.8 nightly test; this is causing collections nightly tests to fail, as latest Prefect 3.x doesn't support it - see PrefectHQ/prefect#13331

giorgiobasile commented 4 months ago

I see 3.8 and 3.10 non-nightly tests failing but I don't think that's related to this PR.

giorgiobasile commented 2 months ago

@discdiver @desertaxle just a reminder on this, is there anything I can/should do on my end?

discdiver commented 1 month ago

@giorgiobasile sorry for the delay. Looks like the 3.9 and higher tests need to pass. If you're able to do that, we can get approved and merged.

Otherwise, I'm not sure how quickly we'll get to the tests passing on our end.

giorgiobasile commented 1 month ago

@giorgiobasile sorry for the delay. Looks like the 3.9 and higher tests need to pass. If you're able to do that, we can get approved and merged.

Otherwise, I'm not sure how quickly we'll get to the tests passing on our end.

Yeah, unfortunately I'm kind of unable to fix them without inputs. Also, I guess there should be some way to test against both Prefect 2 and 3, since they are still both supported, not sure how to proceed with that. So, I guess it's best to wait until somebody from Prefect's team can have a look 👍🏻

desertaxle commented 1 month ago

Hey @giorgiobasile! It looks like we need to update this requirements.txt to only install versions of prefect<3.0.0. I think the workflow jobs will pass if you make that change.

giorgiobasile commented 1 month ago

Hey @giorgiobasile! It looks like we need to update this requirements.txt to only install versions of prefect<3.0.0. I think the workflow jobs will pass if you make that change.

Thanks @desertaxle, that worked indeed, and jobs have passed 👍🏻 I also had to add a conditional import for pydantic.Field based on pydantic's version, not sure if there is a cleaner way to handle it?