search

PrefectHQ / prefect-design

https://prefect-design.netlify.app
Apache License 2.0
29 stars 11 forks source link

Fix auto close not working on PModal #1337

Closed pleek91 closed 4 months ago

pleek91 commented 4 months ago

Description

No local close method existed so it was attempting to call window.close which if the browser didn't prevent it would close the whole tab. Using modalScope.close fixes this. Looks like modalScope use to be destructured and close existed locally. But was lost when the destructure was removed.

netlify[bot] commented 4 months ago

Deploy Preview for prefect-design ready!

Name Link
Latest commit 6c616728fc9b9cab58e7b6cf41698307d190107d
Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/6662191cc25a1a0008f035c3
Deploy Preview https://deploy-preview-1337--prefect-design.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.