PrefectHQ / prefect-design

https://prefect-design.netlify.app
Apache License 2.0
30 stars 11 forks source link

Enhancement: LoadingIcon #243

Open znicholasbrown opened 2 years ago

znicholasbrown commented 2 years ago

Right now the LoadingIcon component isn't in line with our other icons in terms of dimensions / SVG. It should be, probably.

pleek91 commented 2 years ago

@znicholasbrown do we need a new icon made for this? Or is it a matter of adjusting the hero icon?

znicholasbrown commented 2 years ago

We'll need to make a new SVG icon for this; iirc right now it's a series of nicely orchestrated divs

billpalombi commented 2 years ago

Do I understand correctly that this is what we are talking about?

http://g.recordit.co/XrlZq3Q35b.gif

Can an svg be animated like that circle loader?

znicholasbrown commented 2 years ago

Correct @billpalombi (sorry for missing the ping on this before)

And yes, it can be! SVGs can inline CSS and so can provide their own animations using keyframes and / or transitions 😄