Closed GuilleAmutio closed 4 weeks ago
Just to add, worker lint is failing and dont know exactly why.
I removed what i did on the worker, and still failed the lint. Could someone recheck? Thanks
Current error:
==> Linting charts/prefect-worker
[INFO] Chart.yaml: icon is recommended
Error: values.yaml: Expected: valid schema, given: Invalid JSON
Error: templates/: values don't meet the specifications of the schema(s) in the following chart(s):
prefect-worker:
Expected: valid schema, given: Invalid JSON
@GuilleAmutio you'll need two fixes here:
First, the indentation of the labels needs to be corrected:
diff --git a/charts/prefect-worker/templates/deployment.yaml b/charts/prefect-worker/templates/deployment.yaml
index 3cf8a3f..d92cd49 100644
--- a/charts/prefect-worker/templates/deployment.yaml
+++ b/charts/prefect-worker/templates/deployment.yaml
@@ -229,7 +229,7 @@ spec:
whenUnsatisfiable: {{ .whenUnsatisfiable }}
labelSelector:
matchLabels:
- {{- toYaml .labelSelector.matchLabels | nindent 12 }}
+ {{- toYaml .labelSelector.matchLabels | nindent 18 }}
{{- end }}
{{- end }}
volumeMounts:
Second, you'll need to fix the schema:
diff --git a/charts/prefect-worker/values.schema.json b/charts/prefect-worker/values.schema.json
index e3a2a04..1149b2d 100644
--- a/charts/prefect-worker/values.schema.json
+++ b/charts/prefect-worker/values.schema.json
@@ -492,11 +492,11 @@
}
}
}
- }
+ },
+ "required": ["maxSkew", "topologyKey", "whenUnsatisfiable", "labelSelector"]
},
- "required": ["maxSkew", "topologyKey", "whenUnsatisfiable", "labelSelector"]
- },
- "description": "Array of constraints for topology spread of the pods."
+ "description": "Array of constraints for topology spread of the pods."
+ }
}
},
"livenessProbe": {
Hi @mitchnielsen sorry for the delay, fixed, thank you very much for the comment before!
Closing this MR due to conflicts with email used. Gonna reopen
Hi,
This PR allows user to define the SpreadTopologyConstraints for the charts of server and worker.
This feature was requested in https://github.com/PrefectHQ/prefect-helm/issues/360