PrefectHQ / prefect-operator

A Kubernetes operator for managing Prefect servers and work pools
10 stars 0 forks source link

Fix 'make (un)install' commands #96

Closed mitchnielsen closed 1 month ago

mitchnielsen commented 1 month ago

Summary

The wildcard in the 'make (un)install' commands was causing an error locally. At least on my system and shell (zsh), adding the single quotes around the file path fixes it.

Related to https://linear.app/prefect/issue/PLA-289/cycle-2-catch-all

Testing

Before the change:

$ make install
mise all runtimes are installed
pre-commit installed at /Users/mitch/code/github.com/prefecthq/prefect-operator/main/.git/hooks/pre-commit
controller-gen crd webhook paths="./..." output:crd:artifacts:config=deploy/charts/prefect-operator/crds
kubectl apply -f deploy/charts/prefect-operator/crds/*.yaml
error: Unexpected args: [deploy/charts/prefect-operator/crds/prefect.io_prefectworkpools.yaml]
See 'kubectl apply -h' for help and examples
make: *** [install] Error 1

After the change:

$ make install
mise all runtimes are installed
pre-commit installed at /Users/mitch/code/github.com/prefecthq/prefect-operator/main/.git/hooks/pre-commit
controller-gen crd webhook paths="./..." output:crd:artifacts:config=deploy/charts/prefect-operator/crds
kubectl apply -f 'deploy/charts/prefect-operator/crds/*.yaml'
customresourcedefinition.apiextensions.k8s.io/prefectservers.prefect.io unchanged
customresourcedefinition.apiextensions.k8s.io/prefectworkpools.prefect.io unchanged