search

PrefectHQ / prefect-recipes

Snippets and templates representing common Customer Success patterns
https://PrefectHQ.github.io/prefect-recipes/
Apache License 2.0
238 stars 29 forks source link

Remove isort from pre-commit because it conflicts with black #184

Closed zzstoatzz closed 1 year ago

zzstoatzz commented 1 year ago

Description

remove isort from pre-commits because it is at odds with black and will cause an infinite loop of failing, then black changing it back, and so on

also I don't think it provides a lot of value here

ahuang11 commented 1 year ago

I think if setup.cfg is copied from our collections (which makes isort use black as the profile), it will resolve the conflicts. https://github.com/PrefectHQ/prefect-aws/blob/main/setup.cfg

serinamarie commented 1 year ago

I think this is closed by https://github.com/PrefectHQ/prefect-recipes/pull/198