Closed sidharth1805 closed 1 year ago
Hi @sidharth1805, welcome to prefect-recipes ๐งโ๐ณ and congrats on your first contribution! We'll review this very soon ๐
Thank you @serinamarie waiting to get added ๐
@zzstoatzz Have changed the requested
@ahuang11 Please check now ๐
@ahuang11 removed the os library can we run the workflows now ๐
Thanks! It looks good to me. Was wondering if we should put this in beginner flows?
@ahuang11 Sure it would be great ๐
Can I change then?
Yes
@ahuang11 Moved please check now
@sidharth1805 thanks for making these changes, looking good!
one last request from me, since you have log_prints=True
on the flow, you don't need it on the tasks within that flow, since the tasks will inherit the log_prints=True
setting - so can we take that out of the decorator for each task?
@zzstoatzz Done Please check
Thank you @ahuang11 @serinamarie @zzstoatzz this is my first time contribution ๐ . Thank everyone for taking time and reviewing my PR ๐ช.
@sidharth1805 Thanks for creating this recipe! Please reach out to swag@prefect.io for your swag! ๐งข
Description
What's cooking? This PR adds a recipe for using Prefect with SQL alchemy. Issue #149
Type of change
New Recipe Checklist
Add <project-name> recipe