PrefectHQ / prefect-recipes

Snippets and templates representing common Customer Success patterns
https://PrefectHQ.github.io/prefect-recipes/
Apache License 2.0
238 stars 29 forks source link

prefect-sqlalchemy #206

Closed sidharth1805 closed 1 year ago

sidharth1805 commented 1 year ago

Description

What's cooking? This PR adds a recipe for using Prefect with SQL alchemy. Issue #149

Type of change

New Recipe Checklist

serinamarie commented 1 year ago

Hi @sidharth1805, welcome to prefect-recipes ๐Ÿง‘โ€๐Ÿณ and congrats on your first contribution! We'll review this very soon ๐Ÿ™‚

sidharth1805 commented 1 year ago

Thank you @serinamarie waiting to get added ๐Ÿ˜ƒ

sidharth1805 commented 1 year ago

@zzstoatzz Have changed the requested

sidharth1805 commented 1 year ago

@ahuang11 Please check now ๐Ÿ˜ƒ

sidharth1805 commented 1 year ago

@ahuang11 removed the os library can we run the workflows now ๐Ÿ™‚

ahuang11 commented 1 year ago

Thanks! It looks good to me. Was wondering if we should put this in beginner flows?

sidharth1805 commented 1 year ago

@ahuang11 Sure it would be great ๐Ÿ™‚

sidharth1805 commented 1 year ago

Can I change then?

ahuang11 commented 1 year ago

Yes

sidharth1805 commented 1 year ago

@ahuang11 Moved please check now

zzstoatzz commented 1 year ago

@sidharth1805 thanks for making these changes, looking good!

one last request from me, since you have log_prints=True on the flow, you don't need it on the tasks within that flow, since the tasks will inherit the log_prints=True setting - so can we take that out of the decorator for each task?

sidharth1805 commented 1 year ago

@zzstoatzz Done Please check

sidharth1805 commented 1 year ago

Thank you @ahuang11 @serinamarie @zzstoatzz this is my first time contribution ๐Ÿ˜…. Thank everyone for taking time and reviewing my PR ๐Ÿ’ช.

serinamarie commented 1 year ago

@sidharth1805 Thanks for creating this recipe! Please reach out to swag@prefect.io for your swag! ๐Ÿงข