add secrets manager recovery variable

Bee0933 commented 1 year ago

Description

The default behavior of the recovery_window_in_days argument in the aws_secretsmanager_secret resource has been modified by this PR. When the variable is defined, it determines the amount of time that AWS Secrets Manager must wait before deleting the secret. However, if the variable is undefined, the default waiting period will now be applied.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

New Recipe Checklist

[x] My PR is in the format of Add <project-name> recipe
[x] My recipe is reproducible and explains everything needed to run successfully. If my code has external dependencies, I make mention of them.
[x] My code is easily understandable and/or well-commented.
[x] If my recipe requires a new category (e.g. creating a monitoring/ folder in devops/), I have encapsulated my project within its own subfolder so that others can add their own recipes as well.
[x] If my recipe uses Prefect < 2.0, my code is within the prefect-v1-legacy/ folder.

jamiezieziula commented 1 year ago

Thanks for the contribution @Bee0933! Looks like the terraform check is failing. Can you install & run the precommit checks locally? That should fix the formatting error.

Bee0933 commented 1 year ago

Thanks for the contribution @Bee0933! Looks like the terraform check is failing. Can you install & run the precommit checks locally? That should fix the formatting error.

You're welcome! sure, I can do that.

PrefectHQ / prefect-recipes