Updating a deployment with `prefect deploy` says it's creating a new deployment

abrookins commented 4 months ago

First check

[X] I added a descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the Prefect documentation for this issue.
[X] I checked that this issue is related to Prefect and not one of its dependencies.

Bug summary

If I update my prefect.yaml file for a deployment previously created with prefect deploy ... and then run prefect deploy again to update the deployment (this is how I'm supposed to update from the YAML file), the command reports that it created a deployment:

[output removed ...]
 Deployment 'dummy/k8s-memory-test' successfully created with id '35f2550b-fdac-4930-9568-42ec4349348f'.

I selected an existing deployment to use, so this is confusing. However, I seem to still only have one deployment with this name, so an update happened but was reported as a creation.

Reproduction

- Create a deployment with `prefect deploy`
- Change something, such as the working directory, and run `prefect deploy` again
- Choose the existing deployment

Error

No response

Versions

2.16.3

Additional context

No response

serinamarie commented 4 months ago

That makes sense to me that we would want to display that's it's been updated. We should probably do this first and then #12288

eladm26 commented 4 months ago

Hi, @serinamarie would love to take this one.

serinamarie commented 3 months ago

Hi @eladm26, are you still interested in this one?

eladm26 commented 3 months ago

Yeah, hopefully will get into it later this week

On Mon, 15 Apr 2024 at 16:20 Serina Grill @.***> wrote:

Hi @eladm26 https://github.com/eladm26, are you still interested in this one?

— Reply to this email directly, view it on GitHub https://github.com/PrefectHQ/prefect/issues/12287#issuecomment-2056838980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6P43GXK56GVJXBWC4UQNLY5PHYVAVCNFSM6AAAAABEUXMK4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWHAZTQOJYGA . You are receiving this because you were mentioned.Message ID: @.***>

serinamarie commented 3 months ago

Sounds good :)

PrefectHQ / prefect