search

PrefectHQ / prefect

Prefect is a workflow orchestration framework for building resilient data pipelines in Python.
https://prefect.io
Apache License 2.0
16.4k stars 1.59k forks source link

Add a test against a minimum sqlite version #15903

Open discdiver opened 6 days ago

discdiver commented 6 days ago

Describe the current behavior

Our test Matrix doesn't cover older sqlite versions. Users might have an older sqlite version and have the test harness or Prefect server functionality fail due to an old sqlite version.

Describe the proposed behavior

Add a test that specifies the oldest sqlite version we want to test against to the nightly release or CI/CD workflow.

We could then provide helpful information if the version is incompatible. We could also then document this minimum version.

Example Use

No response

Additional context

cc: @j-carson

j-carson commented 6 days ago

If sqlite version are the reason for the issues I've seen, I'd like to have a docs update with clear instructions on how to update your sqlite version (it appears to be tricky if you're not rebuilding your own python)

cicdw commented 6 days ago

Updating sqlite is indeed very tricky, which is why it's important we defer to more official documentation on subjects like that instead of writing and maintaining our own

j-carson commented 6 days ago

Here's the problem - I'm using python3.10 from a pretty standard source (deadsnakes) and prefect_test_harness does not work with that version. If I'm going to go through the hoops to build my own python (still considering my options, but dependencies provided by another team in the company are on python 3.10), I'd like to know which version of sqlite I need to use.

cicdw commented 6 days ago

There's some context missing from this issue so I'm not really sure what we are discussing exactly - what issue are you seeing and why do you think it's related to SQLite versions?