PrefectHQ / terraform-provider-prefect

Terraform Provider for Prefect Cloud
https://registry.terraform.io/providers/PrefectHQ/prefect/latest/docs
Apache License 2.0
33 stars 16 forks source link

Add support for flow, deployment and deployment access resources. #163

Closed skyscrapr closed 3 months ago

skyscrapr commented 5 months ago

Added support for multiple resources:

This PR adds basic support for these resources but does not full implement all attributes for deployments currently. If approved the additional support will be implemented.

All acceptance tests are passing.

Test output:

TBD

skyscrapr commented 5 months ago

Hi. I'll modify the deployment access test to use a service account and that should allow the test to pass.

Can you confirm these tests run in a pro account with ability to create workspaces?

parkedwards commented 5 months ago

@skyscrapr thanks for submitting, we'll review this

Can you confirm these tests run in a pro account with ability to create workspaces?

Yes, the SA used during the test runs has workspace create permissions.

however, i'm seeing these test failures that look odd

https://github.com/PrefectHQ/terraform-provider-prefect/actions/runs/8782258349/job/24114123788

skyscrapr commented 5 months ago

@parkedwards I have engineered these tests to create a workspace and then delete the workspace. This is to ensure the tests work for anyone and does not require the "evergreen" workspace used in the other tests. Can you please confirm that the the workspace can be created. It looks like there is an issue there somewhere.

I can run this test in my environment using a generic api key or a service account api key with admin access.

mitchnielsen commented 3 months ago

Hi @skyscrapr, appreciate the contribution here. Would you be willing to split this PR up so each one adds one resource? As you can probably tell from our merged PRs, we try to keep them as small as possible to make peer reviews more effective. Let us know if you have any questions.

skyscrapr commented 3 months ago

closing this PR and splitting as requested in new PRs