search

PrefectHQ / terraform-provider-prefect

Terraform Provider for Prefect Cloud
https://registry.terraform.io/providers/PrefectHQ/prefect/latest/docs
Apache License 2.0
33 stars 16 forks source link

feat(Deployments): support Job Variables #250

Closed felixpelletier closed 1 month ago

felixpelletier commented 1 month ago

Summary

Supports setting Job Variables on Deployment resources.

Related to https://github.com/PrefectHQ/terraform-provider-prefect/issues/238

Note: I'm a Go newbie, but I mainly just followed the very similar PR here: https://github.com/PrefectHQ/terraform-provider-prefect/pull/245

Testing

I ran the unit tests, but I don't have an appropriate setup to run the acceptance tests. If someone could help with that, I'd be very grateful 😉

mitchnielsen commented 1 month ago

This is great, thanks for your contribution @felixpelletier! Will take a look 👍🏼

mitchnielsen commented 1 month ago

Hi @felixpelletier, I pushed one small change 309ab47. I found that env was a key that works for all work pool types, so I wanted to use that in the example and tests to confirm that your changes work as expected (and they do 👍🏼).