Rename symbols to ensure consistency - Githubissues

PreferredAI / cornac

A Comparative Framework for Multimodal Recommender Systems

https://cornac.preferred.ai

Apache License 2.0

868 stars 142 forks source link

Rename symbols to ensure consistency #565

Closed lthoang closed 9 months ago

lthoang commented 10 months ago

Description

Refactor naming basket_ids to basket_indices and create another basket_ids property in BasketDataset class.

This naming convention is consistent with user_ids and item_ids in Dataset class.

Related Issues

Checklist:

[ ] I have added tests.
[ ] I have updated the documentation accordingly.
[ ] I have updated README.md (if you are adding a new model).
[ ] I have updated examples/README.md (if you are adding a new example).
[ ] I have updated datasets/README.md (if you are adding a new dataset).

tqtg commented 10 months ago

LGTM