search

PreferredAI / cornac

A Comparative Framework for Multimodal Recommender Systems
https://cornac.preferred.ai
Apache License 2.0
845 stars 138 forks source link

Add column model type into table models #588

Closed lthoang closed 5 months ago

lthoang commented 5 months ago

Description

Related Issues

https://github.com/PreferredAI/cornac/issues/585

Checklist:

tqtg commented 5 months ago

Let's keep this open for awhile

tqtg commented 5 months ago

I've tried to provide keywords that best describe the model type/family. If anyone has a better idea, please feel free to contribute.

darrylong commented 5 months ago

Was thinking as this is a long table with many columns, it could be a bit overwhelming.

Ideally we could have a sort feature (by year vs by model type) on this table. But upon checking, I think that is a limitation of MD files.

Just throwing a few possibilities:

  1. Create another "models.md" readme file to sort by model type. (more maintenance required)
  2. Split this table into smaller tables based on categories (longer readme.md file)
  3. Keep it as it is. I think the current table serves its purpose if generally users only care about using the most recent models.

Thanks everyone! :)

tqtg commented 5 months ago

Was thinking as this is a long table with many columns, it could be a bit overwhelming.

Ideally we could have a sort feature (by year vs by model type) on this table. But upon checking, I think that is a limitation of MD files.

Just throwing a few possibilities:

  1. Create another "models.md" readme file to sort by model type. (more maintenance required)
  2. Split this table into smaller tables based on categories (longer readme.md file)
  3. Keep it as it is. I think the current table serves its purpose if generally users only care about using the most recent models.

Thanks everyone! :)

Agree that the current table is a bit long, though splitting into multiple tables will make things look very fragmented. Also, certain categories contain more models than others. I think it's best to keep one table for now until we find a better solution. I'm also thinking about experimenting with html table in markdown but not sure how much GitHub can render it.

tqtg commented 5 months ago

In case no one is having any idea, we can merge this PR the next day. @lthoang