search

PreferredAI / cornac

A Comparative Framework for Multimodal Recommender Systems
https://cornac.preferred.ai
Apache License 2.0
868 stars 142 forks source link

[BUG] Trirank documentation X&Y #618

Closed linan1109 closed 4 months ago

linan1109 commented 4 months ago

For model.Triank, the document says X is for user-aspect and Y is for item-aspect.

But in the code, it should be the other way round, i.e. X for item-aspect and Y for user-aspect.

image

image

tqtg commented 4 months ago

@lthoang is it something to be corrected?

lthoang commented 4 months ago

Based on the original paper, the code is correct. I made a mistake in the model's documentation.

image

So we have to update the documentation accordingly.

@linan1109 Thank you for pointing out this error.